From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from localhost (localhost [127.0.0.1]) by olra.theworths.org (Postfix) with ESMTP id 0D9E6431FAF for ; Fri, 3 Feb 2012 02:29:27 -0800 (PST) X-Virus-Scanned: Debian amavisd-new at olra.theworths.org X-Spam-Flag: NO X-Spam-Score: -0.799 X-Spam-Level: X-Spam-Status: No, score=-0.799 tagged_above=-999 required=5 tests=[DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_LOW=-0.7] autolearn=disabled Received: from olra.theworths.org ([127.0.0.1]) by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id A91J2a2nN56g for ; Fri, 3 Feb 2012 02:29:26 -0800 (PST) Received: from mail-bk0-f53.google.com (mail-bk0-f53.google.com [209.85.214.53]) (using TLSv1 with cipher RC4-SHA (128/128 bits)) (No client certificate requested) by olra.theworths.org (Postfix) with ESMTPS id 485FA431FAE for ; Fri, 3 Feb 2012 02:29:26 -0800 (PST) Received: by bke11 with SMTP id 11so3319774bke.26 for ; Fri, 03 Feb 2012 02:29:24 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=from:to:cc:subject:in-reply-to:references:user-agent:date :message-id:mime-version:content-type; bh=OiZe4tG5llp+uFET8nD+q8QVCVPGNAJzE0shAO8Lijg=; b=E0Leoq2kz9RafoEBFXswEp64oRdZlcpzwaRyfCrlH22ic407HagYrh1Y+uI/n1KNnL 8JrtgH4cC2/2eC1O1fNpJRRodwjRzfNC+Of+fgQlM1f9dd8Bq8NwcSqdFefdyKES5Ddk 9Tnc1NOen0YlsY3rvqTVMcLN67x6ocJUCBYbg= Received: by 10.204.145.210 with SMTP id e18mr3048407bkv.61.1328264964638; Fri, 03 Feb 2012 02:29:24 -0800 (PST) Received: from localhost ([91.144.186.21]) by mx.google.com with ESMTPS id fg16sm15495723bkb.16.2012.02.03.02.29.23 (version=TLSv1/SSLv3 cipher=OTHER); Fri, 03 Feb 2012 02:29:23 -0800 (PST) From: Dmitry Kurochkin To: Pieter Praet Subject: Re: [PATCH] test: replace occurrences of $PWD with vars that are more stable In-Reply-To: <87ty382p6d.fsf@praet.org> References: <87ipjqb8c1.fsf@praet.org> <1328128641-31155-1-git-send-email-pieter@praet.org> <878vkmm9qk.fsf@gmail.com> <87ty382p6d.fsf@praet.org> User-Agent: Notmuch/0.11+139~gd9b7cab (http://notmuchmail.org) Emacs/23.3.1 (x86_64-pc-linux-gnu) Date: Fri, 03 Feb 2012 14:28:09 +0400 Message-ID: <87wr84i53a.fsf@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: Notmuch Mail X-BeenThere: notmuch@notmuchmail.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: "Use and development of the notmuch mail system." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 03 Feb 2012 10:29:27 -0000 On Fri, 03 Feb 2012 11:20:58 +0100, Pieter Praet wrote: > On Thu, 02 Feb 2012 03:09:39 +0400, Dmitry Kurochkin wrote: > > [...] > > I would prefer to put the whole second argument inside the quotes, not > > just the variable. > > [...] > > > > I felt the same way initially, but then decided to leave the extra > quotes in place because the resulting fontification helps differentiate > between the vars and actual strings. > I still prefer it without quotes. > I assume that was the reason for the extra quotes' presence in the first > place? I might be wrong though... > Interesting theory. > So with that in mind, do I submit a new patch without the quotes, or leave > it as it is? > I would not insist on another patch, taking into account that it was this way already. Regards, Dmitry > > Regards, > > Dmitry > > > > > mkdir -p "$(dirname "$external_msg_filename")" > > > mv "$gen_msg_filename" "$external_msg_filename" > > > ln -s "$external_msg_filename" "$gen_msg_filename" > > > -- > > > 1.7.8.1 > > > Peace > > -- > Pieter