[PATCH] emacs: allow to set RETAIN-STATE for `notmuch-show-refresh-view' interactively

[PATCH] emacs: allow to set RETAIN-STATE for `notmuch-show-refresh-view' interactively

[Dmitry Kurochkin]

The notmuch-show view refresh function (`notmuch-show-refresh-view',
bound to "=") accepts an optional RETAIN-STATE argument.  The patch
allows to set this argument interactively by using "C-u =".
---
 emacs/notmuch-show.el |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/emacs/notmuch-show.el b/emacs/notmuch-show.el
index 43408d9..aa9ccee 100644
--- a/emacs/notmuch-show.el
+++ b/emacs/notmuch-show.el
@@ -1124,7 +1124,7 @@ This includes:
 Refreshes the current view, observing changes in display
 preferences. If RETAIN-STATE is non-nil then the state of the
 buffer is stored and re-applied after the refresh."
-  (interactive)
+  (interactive "P")
   (let ((inhibit-read-only t)
 	state)
     (if retain-state
-- 
1.7.9

Re: [PATCH] emacs: allow to set RETAIN-STATE for `notmuch-show-refresh-view' interactively

[Tomi Ollila]

On Mon, 13 Feb 2012 15:09:07 +0400, Dmitry Kurochkin <dmitry.kurochkin@gmail.com> wrote:
> The notmuch-show view refresh function (`notmuch-show-refresh-view',
> bound to "=") accepts an optional RETAIN-STATE argument.  The patch
> allows to set this argument interactively by using "C-u =".
> ---

+1

Tomi

Re: [PATCH] emacs: allow to set RETAIN-STATE for `notmuch-show-refresh-view' interactively

[Austin Clements]

Quoth Dmitry Kurochkin on Feb 13 at  3:09 pm:
> The notmuch-show view refresh function (`notmuch-show-refresh-view',
> bound to "=") accepts an optional RETAIN-STATE argument.  The patch
> allows to set this argument interactively by using "C-u =".

Why do we not *always* want this?

Re: [PATCH] emacs: allow to set RETAIN-STATE for `notmuch-show-refresh-view' interactively

[David Edmondson]

[-- Attachment #1: Type: text/plain, Size: 419 bytes --]

* amdragon@MIT.EDU [2012-02-13 Mon 15:29]
> Quoth Dmitry Kurochkin on Feb 13 at  3:09 pm:
>> The notmuch-show view refresh function (`notmuch-show-refresh-view',
>> bound to "=") accepts an optional RETAIN-STATE argument.  The patch
>> allows to set this argument interactively by using "C-u =".
>
> Why do we not *always* want this?

Because sometimes you want to go back to how things were (or at least
close to it).

[-- Attachment #2: Type: application/pgp-signature, Size: 197 bytes --]

Re: [PATCH] emacs: allow to set RETAIN-STATE for `notmuch-show-refresh-view' interactively

[Dmitry Kurochkin]

On Mon, 13 Feb 2012 10:29:26 -0500, Austin Clements <amdragon@MIT.EDU> wrote:
> Quoth Dmitry Kurochkin on Feb 13 at  3:09 pm:
> > The notmuch-show view refresh function (`notmuch-show-refresh-view',
> > bound to "=") accepts an optional RETAIN-STATE argument.  The patch
> > allows to set this argument interactively by using "C-u =".
> 
> Why do we not *always* want this?

Good point!  I would like to switch the default behavior to retain
state.  Though I do not want to mix a trivial improvement (ability to
use "C-u =") with potentially dangerous discussion of changing the
default behavior :)

Regards,
  Dmitry

Re: [PATCH] emacs: allow to set RETAIN-STATE for `notmuch-show-refresh-view' interactively

[Daniel Schoepe]

[-- Attachment #1: Type: text/plain, Size: 651 bytes --]

On Mon, 13 Feb 2012 10:29:26 -0500, Austin Clements <amdragon@MIT.EDU> wrote:
> Quoth Dmitry Kurochkin on Feb 13 at  3:09 pm:
> > The notmuch-show view refresh function (`notmuch-show-refresh-view',
> > bound to "=") accepts an optional RETAIN-STATE argument.  The patch
> > allows to set this argument interactively by using "C-u =".
> 
> Why do we not *always* want this?

Seconded. And I don't think making that the default along with an easy
way to get the old behavior is "too much" for one patch, even though
"put that in a separate commit!" is a fairly common sentiment here, and
not a bad one, most of the time.

Cheers,
Daniel

[-- Attachment #2: Type: application/pgp-signature, Size: 835 bytes --]

Re: [PATCH] emacs: allow to set RETAIN-STATE for `notmuch-show-refresh-view' interactively

[Tomi Ollila]

On Mon, 13 Feb 2012 20:02:03 +0100, Daniel Schoepe <daniel@schoepe.org> wrote:
> On Mon, 13 Feb 2012 10:29:26 -0500, Austin Clements <amdragon@MIT.EDU> wrote:
> > Quoth Dmitry Kurochkin on Feb 13 at  3:09 pm:
> > > The notmuch-show view refresh function (`notmuch-show-refresh-view',
> > > bound to "=") accepts an optional RETAIN-STATE argument.  The patch
> > > allows to set this argument interactively by using "C-u =".
> > 
> > Why do we not *always* want this?
> 
> Seconded. And I don't think making that the default along with an easy
> way to get the old behavior is "too much" for one patch, even though
> "put that in a separate commit!" is a fairly common sentiment here, and
> not a bad one, most of the time.

I agree. If there is going to be 2 commits, first to change '=' retain
state and second to add previous behaviour by adding prefix argument handling.


> Cheers,
> Daniel

tomi

Re: [PATCH] emacs: allow to set RETAIN-STATE for `notmuch-show-refresh-view' interactively

[David Bremner]

On Mon, 13 Feb 2012 15:09:07 +0400, Dmitry Kurochkin <dmitry.kurochkin@gmail.com> wrote:
> The notmuch-show view refresh function (`notmuch-show-refresh-view',
> bound to "=") accepts an optional RETAIN-STATE argument.  The patch
> allows to set this argument interactively by using "C-u =".

pushed

d