From: David Bremner <david@tethera.net>
To: Jani Nikula <jani@nikula.org>, notmuch@notmuchmail.org
Subject: Re: [PATCH 1/3] cli: refactor "notmuch tag" data structures for tagging operations
Date: Sun, 25 Mar 2012 08:24:42 -0300 [thread overview]
Message-ID: <87wr68zzwl.fsf@zancas.localnet> (raw)
In-Reply-To: <992ada5cb2fa5f89d4f38b10d62f1c178b3174e2.1332604895.git.jani@nikula.org>
On Sat, 24 Mar 2012 18:14:35 +0200, Jani Nikula <jani@nikula.org> wrote:
> To simplify code, keep all tagging operations in a single array
> instead of separate add and remove arrays. Apply tag changes in the
> order specified on the command line, instead of first removing and
> then adding the tags.
Like I said on IRC, my only minor reservation with this patch is that
the use of C99 struct assignment is maybe not a good tradeoff here,
since it makes the code a bit more mysterious (for the great unwashed
masses that don't know C99 as well as C89). Still, if you think extra
initialization features are worth it, I can live with it.
d
next prev parent reply other threads:[~2012-03-25 11:24 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-03-24 16:14 [PATCH 0/3] cli: notmuch tag/restore refactoring Jani Nikula
2012-03-24 16:14 ` [PATCH 1/3] cli: refactor "notmuch tag" data structures for tagging operations Jani Nikula
2012-03-24 18:58 ` David Bremner
2012-03-25 11:24 ` David Bremner [this message]
2012-03-24 16:14 ` [PATCH 2/3] cli: refactor "notmuch tag" query tagging into a separate function Jani Nikula
2012-03-24 16:14 ` [PATCH 3/3] cli: refactor "notmuch restore" message " Jani Nikula
2012-03-25 13:33 ` David Bremner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://notmuchmail.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87wr68zzwl.fsf@zancas.localnet \
--to=david@tethera.net \
--cc=jani@nikula.org \
--cc=notmuch@notmuchmail.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://yhetil.org/notmuch.git/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).