[PATCH] emacs: Fix mis-named argument to notmuch-get-bodypart-internal

[PATCH] emacs: Fix mis-named argument to notmuch-get-bodypart-internal

[Austin Clements]

Previously, this function took an argument called "message-id", even
though it was a general query, rather than a message ID.  This changes
it to "query".
---
 emacs/notmuch-lib.el |    4 ++--
 1 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/emacs/notmuch-lib.el b/emacs/notmuch-lib.el
index 2e367b5..4b17ecc 100644
--- a/emacs/notmuch-lib.el
+++ b/emacs/notmuch-lib.el
@@ -219,13 +219,13 @@ the given type."
 
 ;; Helper for parts which are generally not included in the default
 ;; JSON output.
-(defun notmuch-get-bodypart-internal (message-id part-number process-crypto)
+(defun notmuch-get-bodypart-internal (query part-number process-crypto)
   (let ((args '("show" "--format=raw"))
 	(part-arg (format "--part=%s" part-number)))
     (setq args (append args (list part-arg)))
     (if process-crypto
 	(setq args (append args '("--decrypt"))))
-    (setq args (append args (list message-id)))
+    (setq args (append args (list query)))
     (with-temp-buffer
       (let ((coding-system-for-read 'no-conversion))
 	(progn
-- 
1.7.7.2

Re: [PATCH] emacs: Fix mis-named argument to notmuch-get-bodypart-internal

[Tomi Ollila]

On Tue, Mar 27 2012, Austin Clements <amdragon@MIT.EDU> wrote:

> Previously, this function took an argument called "message-id", even
> though it was a general query, rather than a message ID.  This changes
> it to "query".
> ---

+1 

Tomi


>  emacs/notmuch-lib.el |    4 ++--
>  1 files changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/emacs/notmuch-lib.el b/emacs/notmuch-lib.el
> index 2e367b5..4b17ecc 100644
> --- a/emacs/notmuch-lib.el
> +++ b/emacs/notmuch-lib.el
> @@ -219,13 +219,13 @@ the given type."
>  
>  ;; Helper for parts which are generally not included in the default
>  ;; JSON output.
> -(defun notmuch-get-bodypart-internal (message-id part-number process-crypto)
> +(defun notmuch-get-bodypart-internal (query part-number process-crypto)
>    (let ((args '("show" "--format=raw"))
>  	(part-arg (format "--part=%s" part-number)))
>      (setq args (append args (list part-arg)))
>      (if process-crypto
>  	(setq args (append args '("--decrypt"))))
> -    (setq args (append args (list message-id)))
> +    (setq args (append args (list query)))
>      (with-temp-buffer
>        (let ((coding-system-for-read 'no-conversion))
>  	(progn
> -- 
> 1.7.7.2
>
> _______________________________________________
> notmuch mailing list
> notmuch@notmuchmail.org
> http://notmuchmail.org/mailman/listinfo/notmuch

Re: [PATCH] emacs: Fix mis-named argument to notmuch-get-bodypart-internal

[Jameson Graef Rollins]

[-- Attachment #1: Type: text/plain, Size: 574 bytes --]

On Mon, Mar 26 2012, Austin Clements <amdragon@MIT.EDU> wrote:
> Previously, this function took an argument called "message-id", even
> though it was a general query, rather than a message ID.  This changes
> it to "query".

I'm sure the argument was named such because: the function is retrieving
a message part so the query has to match just a single message, and it's
only ever given a message id by anything that calls it.  And it's an
unexposed internal function.  All of this to say that I think it doesn't
really matter that the argument was named as it was.

jamie.

[-- Attachment #2: Type: application/pgp-signature, Size: 835 bytes --]

Re: [PATCH] emacs: Fix mis-named argument to notmuch-get-bodypart-internal

[Austin Clements]

Quoth Jameson Graef Rollins on Mar 28 at  6:46 pm:
> On Mon, Mar 26 2012, Austin Clements <amdragon@MIT.EDU> wrote:
> > Previously, this function took an argument called "message-id", even
> > though it was a general query, rather than a message ID.  This changes
> > it to "query".
> 
> I'm sure the argument was named such because: the function is retrieving
> a message part so the query has to match just a single message, and it's
> only ever given a message id by anything that calls it.  And it's an
> unexposed internal function.  All of this to say that I think it doesn't
> really matter that the argument was named as it was.

All true.  But there's a difference between a message ID and an id:
query and the argument name threw me off for a moment when I was
writing the id: query quoting patch.  It could be `id-query', I
suppose, but really it could be any query that matches a single
message.

Re: [PATCH] emacs: Fix mis-named argument to notmuch-get-bodypart-internal

[Jameson Graef Rollins]

[-- Attachment #1: Type: text/plain, Size: 438 bytes --]

On Wed, Mar 28 2012, Austin Clements <amdragon@MIT.EDU> wrote:
> All true.  But there's a difference between a message ID and an id:
> query and the argument name threw me off for a moment when I was
> writing the id: query quoting patch.  It could be `id-query', I
> suppose, but really it could be any query that matches a single
> message.

Fair enough.  And it's good to have things named correctly and
consistently, so LGTM.

jamie.

[-- Attachment #2: Type: application/pgp-signature, Size: 835 bytes --]

Re: [PATCH] emacs: Fix mis-named argument to notmuch-get-bodypart-internal

[David Bremner]

Austin Clements <amdragon@MIT.EDU> writes:

> Previously, this function took an argument called "message-id", even
> though it was a general query, rather than a message ID.  This changes
> it to "query".

pushed, 

d

Re: [PATCH] emacs: Fix mis-named argument to notmuch-get-bodypart-internal

[David Bremner]

Austin Clements <amdragon@MIT.EDU> writes:

> Previously, this function took an argument called "message-id", even
> though it was a general query, rather than a message ID.  This changes
> it to "query".

Pushed,

d