From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from localhost (localhost [127.0.0.1]) by olra.theworths.org (Postfix) with ESMTP id CD10C431FAE for ; Sun, 22 Apr 2012 11:07:01 -0700 (PDT) X-Virus-Scanned: Debian amavisd-new at olra.theworths.org X-Spam-Flag: NO X-Spam-Score: -0.7 X-Spam-Level: X-Spam-Status: No, score=-0.7 tagged_above=-999 required=5 tests=[RCVD_IN_DNSWL_LOW=-0.7] autolearn=disabled Received: from olra.theworths.org ([127.0.0.1]) by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id ARNz0npJAY42 for ; Sun, 22 Apr 2012 11:07:01 -0700 (PDT) Received: from dmz-mailsec-scanner-4.mit.edu (DMZ-MAILSEC-SCANNER-4.MIT.EDU [18.9.25.15]) by olra.theworths.org (Postfix) with ESMTP id 3694E431FAF for ; Sun, 22 Apr 2012 11:07:01 -0700 (PDT) X-AuditID: 1209190f-b7f8a6d000000914-82-4f9448c44bd4 Received: from mailhub-auth-1.mit.edu ( [18.9.21.35]) by dmz-mailsec-scanner-4.mit.edu (Symantec Messaging Gateway) with SMTP id C9.BC.02324.4C8449F4; Sun, 22 Apr 2012 14:07:00 -0400 (EDT) Received: from outgoing.mit.edu (OUTGOING-AUTH.MIT.EDU [18.7.22.103]) by mailhub-auth-1.mit.edu (8.13.8/8.9.2) with ESMTP id q3MI70Le020364; Sun, 22 Apr 2012 14:07:00 -0400 Received: from awakening.csail.mit.edu (awakening.csail.mit.edu [18.26.4.91]) (authenticated bits=0) (User authenticated as amdragon@ATHENA.MIT.EDU) by outgoing.mit.edu (8.13.6/8.12.4) with ESMTP id q3MI6x1u019455 (version=TLSv1/SSLv3 cipher=AES256-SHA bits=256 verify=NOT); Sun, 22 Apr 2012 14:06:59 -0400 (EDT) Received: from amthrax by awakening.csail.mit.edu with local (Exim 4.77) (envelope-from ) id 1SM1Ba-00080L-TJ; Sun, 22 Apr 2012 14:06:58 -0400 From: Austin Clements To: Justus Winter <4winter@informatik.uni-hamburg.de>, notmuch@notmuchmail.org Subject: Re: [PATCH 1/7] Split notmuch_database_close into two functions In-Reply-To: <1335096477-27537-1-git-send-email-4winter@informatik.uni-hamburg.de> References: <20120422120620.26225.40778@thinkbox.jade-hamburg.de> <1335096477-27537-1-git-send-email-4winter@informatik.uni-hamburg.de> User-Agent: Notmuch/0.12+132~gf2f390b (http://notmuchmail.org) Emacs/23.3.1 (i486-pc-linux-gnu) Date: Sun, 22 Apr 2012 14:06:58 -0400 Message-ID: <87wr57hc8t.fsf@awakening.csail.mit.edu> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFnrMIsWRmVeSWpSXmKPExsUixCmqrHvEY4q/wfsFphazW38wWVy/OZPZ gclj4vnTbB7PVt1iDmCK4rJJSc3JLEst0rdL4MpYeKmZqWAtW8XEky+YGxhXsXYxcnJICJhI 3Nk0gx3CFpO4cG89WxcjF4eQwD5Giad7v0A5Gxgl1t3dzwzhnGSS+Hv7GyOEs4RR4uKbhWCz 2AQ0JLbtX84IYosI+Em8ejiHCcQWFvCQ2HFtD1icUyBIYu3qRqjmdkaJg78Wgi0XFYiX+NO7 mQ3EZhFQlfi7cjtYAy/Qgbv3HWGFsAUlTs58wgJiMwtoSdz495JpAqPALCSpWUhSCxiZVjHK puRW6eYmZuYUpybrFicn5uWlFuma6OVmluilppRuYgSHpST/DsZvB5UOMQpwMCrx8L4ymewv xJpYVlyZe4hRkoNJSZQ3BBjUQnxJ+SmVGYnFGfFFpTmpxYcYJTiYlUR4P4sAlfOmJFZWpRbl w6SkOViUxHnVtN75CQmkJ5akZqemFqQWwWRlODiUJHg1QIYKFqWmp1akZeaUIKSZODhBhvMA DVcGqeEtLkjMLc5Mh8ifYlSUEud95w6UEABJZJTmwfXC0sYrRnGgV4R52UDaeYApB677FdBg JqDBCTGTQAaXJCKkpBoY+7curpwvMd05obYxYAL/ldxVXGZ3/O5wm7/esHrheqMpmpc9t2rZ HM2aEXPN5cuWA1N7LDweNvT4vevNDFztsfXf65uuNQdfXSreojljBc+nsEIz35t8QU/spQUj 21LFDMKmfW/fmXNtU+Jq+R8fJ1RNySl/mH3r1trzvbOVpfhCkhY857reqsRSnJFoqMVcVJwI AJUR5Ar2AgAA X-BeenThere: notmuch@notmuchmail.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: "Use and development of the notmuch mail system." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 22 Apr 2012 18:07:01 -0000 On Sun, 22 Apr 2012, Justus Winter <4winter@informatik.uni-hamburg.de> wrote: > Formerly notmuch_database_close closed the xapian database and > destroyed the talloc structure associated with the notmuch database > object. Split notmuch_database_close into notmuch_database_close and > notmuch_database_destroy. > > This makes it possible for long running programs to close the xapian > database and thus release the lock associated with it without > destroying the data structures obtained from it. > > This also makes the api more consistent since every other data > structure has a destructor function. > > Signed-off-by: Justus Winter <4winter@informatik.uni-hamburg.de> Other than my comments comment, this series LGTM. I think adding those comments should also address Felipe's question.