unofficial mirror of notmuch@notmuchmail.org
 help / color / mirror / code / Atom feed
From: Mark Walters <markwalters1009@gmail.com>
To: Jani Nikula <jani@nikula.org>, notmuch@notmuchmail.org
Subject: Re: [PATCH v2] emacs: add support for stashing the thread id in show view
Date: Fri, 07 Dec 2012 07:53:18 +0000	[thread overview]
Message-ID: <87wqwu5mdt.fsf@qmul.ac.uk> (raw)
In-Reply-To: <1354834085-8225-1-git-send-email-jani@nikula.org>

Jani Nikula <jani@nikula.org> writes:

> Add a prefix argument to notmuch-show-stash-message-id to stash thread
> id instead of message id.


LGTM +1

Mark


> ---
>  emacs/notmuch-show.el |   14 ++++++++++----
>  1 file changed, 10 insertions(+), 4 deletions(-)
>
> diff --git a/emacs/notmuch-show.el b/emacs/notmuch-show.el
> index 4d6c014..658a2be 100644
> --- a/emacs/notmuch-show.el
> +++ b/emacs/notmuch-show.el
> @@ -1901,10 +1901,16 @@ thread from search."
>    (interactive)
>    (notmuch-common-do-stash (notmuch-show-get-from)))
>  
> -(defun notmuch-show-stash-message-id ()
> -  "Copy id: query matching the current message to kill-ring."
> -  (interactive)
> -  (notmuch-common-do-stash (notmuch-show-get-message-id)))
> +(defun notmuch-show-stash-message-id (&optional stash-thread-id)
> +  "Copy id: query matching the current message to kill-ring.
> +
> +If invoked with a prefix argument (or STASH-THREAD-ID is
> +non-nil), copy thread: query matching the current thread to
> +kill-ring."
> +  (interactive "P")
> +  (if stash-thread-id
> +      (notmuch-common-do-stash notmuch-show-thread-id)
> +    (notmuch-common-do-stash (notmuch-show-get-message-id))))
>  
>  (defun notmuch-show-stash-message-id-stripped ()
>    "Copy message ID of current message (sans `id:' prefix) to kill-ring."
> -- 
> 1.7.10.4

  reply	other threads:[~2012-12-07  7:53 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-12-06 20:57 [PATCH] emacs: add support for stashing the thread id in show view Jani Nikula
2012-12-06 22:35 ` Mark Walters
2012-12-06 22:48   ` [PATCH v2] " Jani Nikula
2012-12-07  7:53     ` Mark Walters [this message]
2012-12-07 22:25     ` Tomi Ollila
2012-12-09 23:12     ` David Bremner

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://notmuchmail.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87wqwu5mdt.fsf@qmul.ac.uk \
    --to=markwalters1009@gmail.com \
    --cc=jani@nikula.org \
    --cc=notmuch@notmuchmail.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://yhetil.org/notmuch.git/

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).