From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from localhost (localhost [127.0.0.1]) by olra.theworths.org (Postfix) with ESMTP id E850F431FB6 for ; Tue, 25 Dec 2012 04:26:24 -0800 (PST) X-Virus-Scanned: Debian amavisd-new at olra.theworths.org X-Spam-Flag: NO X-Spam-Score: 0 X-Spam-Level: X-Spam-Status: No, score=0 tagged_above=-999 required=5 tests=[none] autolearn=disabled Received: from olra.theworths.org ([127.0.0.1]) by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id NGzCUqkESBgZ for ; Tue, 25 Dec 2012 04:26:24 -0800 (PST) Received: from tesseract.cs.unb.ca (tesseract.cs.unb.ca [131.202.240.238]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (No client certificate requested) by olra.theworths.org (Postfix) with ESMTPS id 9022C431FAE for ; Tue, 25 Dec 2012 04:26:24 -0800 (PST) Received: from fctnnbsc30w-156034082078.dhcp-dynamic.fibreop.nb.bellaliant.net ([156.34.82.78] helo=zancas.localnet) by tesseract.cs.unb.ca with esmtpsa (TLS1.0:DHE_RSA_AES_128_CBC_SHA1:16) (Exim 4.72) (envelope-from ) id 1TnTaM-0001Ot-6D; Tue, 25 Dec 2012 08:26:18 -0400 Received: from bremner by zancas.localnet with local (Exim 4.80) (envelope-from ) id 1TnTZv-0003Pv-AX; Tue, 25 Dec 2012 08:25:51 -0400 From: David Bremner To: Austin Clements , notmuch@notmuchmail.org Subject: Re: [PATCH 1/5] util: Factor out boolean term quoting routine In-Reply-To: <1356415076-5692-2-git-send-email-amdragon@mit.edu> References: <1356415076-5692-1-git-send-email-amdragon@mit.edu> <1356415076-5692-2-git-send-email-amdragon@mit.edu> User-Agent: Notmuch/0.14+213~g4af1ac6 (http://notmuchmail.org) Emacs/24.2.1 (x86_64-pc-linux-gnu) Date: Tue, 25 Dec 2012 08:25:51 -0400 Message-ID: <87wqw6e2sw.fsf@zancas.localnet> MIME-Version: 1.0 Content-Type: text/plain X-Spam_bar: - X-BeenThere: notmuch@notmuchmail.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: "Use and development of the notmuch mail system." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 25 Dec 2012 12:26:25 -0000 Austin Clements writes: > > This could live in tag-util as well, but it is really nothing specific > to tags (although the conventions are specific to Xapian). > > Furthermore, this now combines the term prefix with the quoted term; > arguably this is just as easy to do in the caller, but this will > nicely parallel the boolean term parsing function to be introduced > shortly. At first glance, I found this a bit too notmuch-specific to go in util. On second glance, I found my first reaction somewhat bizarre. Perhaps at some point we should drop a README file in util explaining what should go there. Other than that, LGTM d