unofficial mirror of notmuch@notmuchmail.org
 help / color / mirror / code / Atom feed
From: David Bremner <david@tethera.net>
To: Tomi Ollila <tomi.ollila@iki.fi>, notmuch@notmuchmail.org
Subject: Re: [PATCH v2 5/5] compact: provide user more information on after-compaction failures
Date: Sun, 17 Nov 2013 20:53:38 -0400	[thread overview]
Message-ID: <87wqk6y1gt.fsf@zancas.localnet> (raw)
In-Reply-To: <m2pppzm4ja.fsf@guru.guru-group.fi>

Tomi Ollila <tomi.ollila@iki.fi> writes:
> I was thinking naming the function notmuch_database_compact_internal ()
> as one option (I also though of notmuch_database_compact_unstable () -- but
> that sounds so "unstable" (at least outside Debian people ;D)) --
> could be one option. Then developers should understand the API is not
> fixed there...

I think 0.18 will just be an API breaking release in general; compact is
probably the least of people's worries. Yes, it's a bit more irritating
because the API will be short lived, but since we plan to change
notmuch_database_open, pretty much every client of the library will have
to update anyway. Luckily there probably aren't enough such clients to
get a really good lynch mob together.  I'd suggest just mentioning it
NEWS for 0.17 that the library interface for compact is expected to
change in 0.18.

d

      reply	other threads:[~2013-11-18  0:53 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-11-13 17:02 compactor adjustments v2 Tomi Ollila
2013-11-13 17:02 ` [PATCH v2 1/5] compact: tidy formatting Tomi Ollila
2013-11-13 17:02 ` [PATCH v2 2/5] compact: catch Xapian::Error consistently Tomi Ollila
2013-11-14 14:13   ` Jani Nikula
2013-11-18  0:33   ` David Bremner
2013-11-13 17:02 ` [PATCH v2 3/5] compact: preserve backup database until compacted database is in place Tomi Ollila
2013-11-14 14:08   ` Jani Nikula
2013-11-13 17:02 ` [PATCH v2 4/5] compact: unconditionally attempt to remove old wip database compact directory Tomi Ollila
2013-11-14 14:02   ` Jani Nikula
2013-11-13 17:02 ` [PATCH v2 5/5] compact: provide user more information on after-compaction failures Tomi Ollila
2013-11-14 14:13   ` Jani Nikula
2013-11-14 16:11     ` David Bremner
2013-11-14 17:23       ` Tomi Ollila
2013-11-17 11:34         ` David Bremner
2013-11-17 15:28           ` Tomi Ollila
2013-11-18  0:53             ` David Bremner [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://notmuchmail.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87wqk6y1gt.fsf@zancas.localnet \
    --to=david@tethera.net \
    --cc=notmuch@notmuchmail.org \
    --cc=tomi.ollila@iki.fi \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://yhetil.org/notmuch.git/

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).