Forwarding a mail, with a non-ASCII signature

Forwarding a mail, with a non-ASCII signature

[Lele Gaifax]

Hi all,

as you can see below, my signature contains some non-ASCII characters,
and it is stored as UTF-8 (I have `(prefer-coding-system 'utf-8)` in my
.emacs.el) in my home as ~/.signature.

Recently I started using notmuch with Emacs as the main MUA, using
message-mode to send emails. I'm *very* satisfied, BTW!

Everything works great, except that when I "forward" an email message:
in that case, the "*unsent mail*" buffer contains the original message
within a "#mml" tag, followed by my signature, apparently appended as
binary (e.g. instead of "vivrò" I see "vivr\303\262"). When I try to
send it, I get the "Unreadable characters" prompt...

I quickly inspected what notmuch-show-forward-message does, but AFAICT
it does very little, delegating most of the work to message-mode: but
doing the same from Gnus works ok, so I must be missing something.

I also tried tweaking the message-default-charset, changing it from nil
to utf-8, with the very same result.

I'm using Emacs 24.4.51 compiled a few days ago, if that matters.

Thank you for any hint,
ciao, lele.
-- 
nickname: Lele Gaifax | Quando vivrò di quello che ho pensato ieri
real: Emanuele Gaifas | comincerò ad aver paura di chi mi copia.
lele@metapensiero.it  |                 -- Fortunato Depero, 1929.

Re: Forwarding a mail, with a non-ASCII signature

[Jani Nikula]

On Sun, 16 Nov 2014, Lele Gaifax <lele@metapensiero.it> wrote:
> Recently I started using notmuch with Emacs as the main MUA, using
> message-mode to send emails. I'm *very* satisfied, BTW!

It doesn't seem to matter here, but are you really not using
notmuch-mua-new-mail to send emails? Your User-Agent field seems to
concur:

User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.4.51 (gnu/linux)

> Everything works great, except that when I "forward" an email message:
> in that case, the "*unsent mail*" buffer contains the original message
> within a "#mml" tag, followed by my signature, apparently appended as
> binary (e.g. instead of "vivrò" I see "vivr\303\262"). When I try to
> send it, I get the "Unreadable characters" prompt...

I can reproduce this.


BR,
Jani.

Re: Forwarding a mail, with a non-ASCII signature

[Lele Gaifax]

Jani Nikula <jani@nikula.org> writes:

> On Sun, 16 Nov 2014, Lele Gaifax <lele@metapensiero.it> wrote:
>> Recently I started using notmuch with Emacs as the main MUA, using
>> message-mode to send emails. I'm *very* satisfied, BTW!
>
> It doesn't seem to matter here, but are you really not using
> notmuch-mua-new-mail to send emails? Your User-Agent field seems to
> concur:
>
> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.4.51 (gnu/linux)

Yes, I prefer interacting with most ML thru gmane.org, so this message
originated from Gnus.

ciao, lele.
-- 
nickname: Lele Gaifax | Quando vivrò di quello che ho pensato ieri
real: Emanuele Gaifas | comincerò ad aver paura di chi mi copia.
lele@metapensiero.it  |                 -- Fortunato Depero, 1929.

Re: Forwarding a mail, with a non-ASCII signature

[David Edmondson]

On Sun, Nov 16 2014, Lele Gaifax wrote:
> Hi all,
>
> as you can see below, my signature contains some non-ASCII characters,
> and it is stored as UTF-8 (I have `(prefer-coding-system 'utf-8)` in my
> .emacs.el) in my home as ~/.signature.
>
> Recently I started using notmuch with Emacs as the main MUA, using
> message-mode to send emails. I'm *very* satisfied, BTW!
>
> Everything works great, except that when I "forward" an email message:
> in that case, the "*unsent mail*" buffer contains the original message
> within a "#mml" tag, followed by my signature, apparently appended as
> binary (e.g. instead of "vivrò" I see "vivr\303\262"). When I try to
> send it, I get the "Unreadable characters" prompt...
>
> I quickly inspected what notmuch-show-forward-message does, but AFAICT
> it does very little, delegating most of the work to message-mode: but
> doing the same from Gnus works ok, so I must be missing something.
>
> I also tried tweaking the message-default-charset, changing it from nil
> to utf-8, with the very same result.
>
> I'm using Emacs 24.4.51 compiled a few days ago, if that matters.

How do you insert the signature? That is, do you have some bits of
configuration that add the signature to outgoing messages?

> Thank you for any hint,
> ciao, lele.
> -- 
> nickname: Lele Gaifax | Quando vivrò di quello che ho pensato ieri
> real: Emanuele Gaifas | comincerò ad aver paura di chi mi copia.
> lele@metapensiero.it  |                 -- Fortunato Depero, 1929.
>
> _______________________________________________
> notmuch mailing list
> notmuch@notmuchmail.org
> http://notmuchmail.org/mailman/listinfo/notmuch

Re: Forwarding a mail, with a non-ASCII signature

[Lele Gaifax]

David Edmondson <dme@dme.org> writes:

> How do you insert the signature? That is, do you have some bits of
> configuration that add the signature to outgoing messages?

Nothing special, just the following config snippet in my .gnus.el::

    (setq gnus-posting-styles
          '((".*"
             (signature-file "~/.signature")
             (name "Lele Gaifax")
             (organization "Nautilus Entertainments"))))

> Could you try this patch please?
> 
> diff --git a/emacs/notmuch-show.el b/emacs/notmuch-show.el
> index 6e03f1e..1592ca9 100644
> --- a/emacs/notmuch-show.el
> +++ b/emacs/notmuch-show.el
> @@ -235,9 +235,9 @@ For example, if you wanted to remove an \"unread\" tag and add a
>         (let ((buf (generate-new-buffer (concat "*notmuch-msg-" id "*"))))
>           (with-current-buffer buf
>  	   (let ((coding-system-for-read 'no-conversion))
> -	     (call-process notmuch-command nil t nil "show" "--format=raw" id)
> -	     ,@body)
> -	   (kill-buffer buf))))))
> +	     (call-process notmuch-command nil t nil "show" "--format=raw" id))
> +	   ,@body)
> +	 (kill-buffer buf)))))
>  
>  (defun notmuch-show-turn-on-visual-line-mode ()
>    "Enable Visual Line mode."

Yes! This works great, with it the forward buffer contains the signature
loaded with the correct encoding, and the sendmail succeeds without
prompting about unreadable chars.

Thanks a lot for fixing it,
ciao, lele.
-- 
nickname: Lele Gaifax | Quando vivrò di quello che ho pensato ieri
real: Emanuele Gaifas | comincerò ad aver paura di chi mi copia.
lele@metapensiero.it  |                 -- Fortunato Depero, 1929.

Re: Forwarding a mail, with a non-ASCII signature

[David Edmondson]

On Mon, Nov 17 2014, Lele Gaifax wrote:
>> Could you try this patch please?
>> 
>> diff --git a/emacs/notmuch-show.el b/emacs/notmuch-show.el
>> index 6e03f1e..1592ca9 100644
>> --- a/emacs/notmuch-show.el
>> +++ b/emacs/notmuch-show.el
>> @@ -235,9 +235,9 @@ For example, if you wanted to remove an \"unread\" tag and add a
>>         (let ((buf (generate-new-buffer (concat "*notmuch-msg-" id "*"))))
>>           (with-current-buffer buf
>>  	   (let ((coding-system-for-read 'no-conversion))
>> -	     (call-process notmuch-command nil t nil "show" "--format=raw" id)
>> -	     ,@body)
>> -	   (kill-buffer buf))))))
>> +	     (call-process notmuch-command nil t nil "show" "--format=raw" id))
>> +	   ,@body)
>> +	 (kill-buffer buf)))))
>>  
>>  (defun notmuch-show-turn-on-visual-line-mode ()
>>    "Enable Visual Line mode."
>
> Yes! This works great, with it the forward buffer contains the signature
> loaded with the correct encoding, and the sendmail succeeds without
> prompting about unreadable chars.

That's good, thanks for testing. I'll work up and submit a proper patch.

Re: Forwarding a mail, with a non-ASCII signature

[David Edmondson]

On Mon, Nov 17 2014, David Edmondson wrote:
>>
>> Yes! This works great, with it the forward buffer contains the signature
>> loaded with the correct encoding, and the sendmail succeeds without
>> prompting about unreadable chars.
>
> That's good, thanks for testing. I'll work up and submit a proper patch.

id:1416294197-3170-1-git-send-email-dme@dme.org

Re: Forwarding a mail, with a non-ASCII signature

[David Edmondson]

On Sun, Nov 16 2014, Lele Gaifax wrote:
> Hi all,
>
> as you can see below, my signature contains some non-ASCII characters,
> and it is stored as UTF-8 (I have `(prefer-coding-system 'utf-8)` in my
> .emacs.el) in my home as ~/.signature.
>
> Recently I started using notmuch with Emacs as the main MUA, using
> message-mode to send emails. I'm *very* satisfied, BTW!
>
> Everything works great, except that when I "forward" an email message:
> in that case, the "*unsent mail*" buffer contains the original message
> within a "#mml" tag, followed by my signature, apparently appended as
> binary (e.g. instead of "vivrò" I see "vivr\303\262"). When I try to
> send it, I get the "Unreadable characters" prompt...
>
> I quickly inspected what notmuch-show-forward-message does, but AFAICT
> it does very little, delegating most of the work to message-mode: but
> doing the same from Gnus works ok, so I must be missing something.
>
> I also tried tweaking the message-default-charset, changing it from nil
> to utf-8, with the very same result.
>
> I'm using Emacs 24.4.51 compiled a few days ago, if that matters.

Could you try this patch please?

diff --git a/emacs/notmuch-show.el b/emacs/notmuch-show.el
index 6e03f1e..1592ca9 100644
--- a/emacs/notmuch-show.el
+++ b/emacs/notmuch-show.el
@@ -235,9 +235,9 @@ For example, if you wanted to remove an \"unread\" tag and add a
        (let ((buf (generate-new-buffer (concat "*notmuch-msg-" id "*"))))
          (with-current-buffer buf
 	   (let ((coding-system-for-read 'no-conversion))
-	     (call-process notmuch-command nil t nil "show" "--format=raw" id)
-	     ,@body)
-	   (kill-buffer buf))))))
+	     (call-process notmuch-command nil t nil "show" "--format=raw" id))
+	   ,@body)
+	 (kill-buffer buf)))))
 
 (defun notmuch-show-turn-on-visual-line-mode ()
   "Enable Visual Line mode."

Re: Forwarding a mail, with a non-ASCII signature

[David Bremner]

Lele Gaifax <lele@metapensiero.it> writes:

> Hi all,
>
> as you can see below, my signature contains some non-ASCII characters,
> and it is stored as UTF-8 (I have `(prefer-coding-system 'utf-8)` in my
> .emacs.el) in my home as ~/.signature.

This bug should be fixed in commit

     0.19+3-g7585e8ca (as of this moment, notmuch master)

d

Re: Forwarding a mail, with a non-ASCII signature

[Lele Gaifax]

David Bremner <david@tethera.net> writes:

> Lele Gaifax <lele@metapensiero.it> writes:
>
>> Hi all,
>>
>> as you can see below, my signature contains some non-ASCII characters,
>> and it is stored as UTF-8 (I have `(prefer-coding-system 'utf-8)` in my
>> .emacs.el) in my home as ~/.signature.
>
> This bug should be fixed in commit
>
>      0.19+3-g7585e8ca (as of this moment, notmuch master)
>

Thanks a lot, waiting to see it landing on the MELPA archive.

ciao, lele.
-- 
nickname: Lele Gaifax | Quando vivrò di quello che ho pensato ieri
real: Emanuele Gaifas | comincerò ad aver paura di chi mi copia.
lele@metapensiero.it  |                 -- Fortunato Depero, 1929.

Re: Forwarding a mail, with a non-ASCII signature

[David Bremner]

Lele Gaifax <lele@metapensiero.it> writes:
>>
>
> Thanks a lot, waiting to see it landing on the MELPA archive.
>
> ciao, lele.

Just be aware that people have had problems in the past using versions
from MELPA because they ship only the elisp and not the corresponding C
code.  Hopefully it works better now, or at least detects dangerous
version mismatches between the elisp and C code.

d