From: David Bremner <david@tethera.net>
To: l-m-h@web.de, notmuch@notmuchmail.org
Cc: Lucas Hoffmann <l-m-h@web.de>
Subject: Re: [PATCH 2/2] python: add convenience function to get named queries
Date: Sat, 10 Jun 2017 08:37:07 -0300 [thread overview]
Message-ID: <87wp8kcbvg.fsf@tethera.net> (raw)
In-Reply-To: <34d9febc53775a24ca9e1bb1abcef64ea9196b12.1496596853.git.l-m-h@web.de>
l-m-h@web.de writes:
see above re: commit messages.
> ---
> bindings/python/notmuch/database.py | 7 +++++++
> 1 file changed, 7 insertions(+)
>
> +
> + def get_all_named_queries(self):
> + """Returns a dict of all named queries mapped to their search queries.
> +
> + This function is a python extension and not in the underlying C API.
> + """
> + return {k[6:]: v for k, v in self.get_config_list('query.')}
I have somewhat mixed feelings about this. I don't really like the
python bindings diverging from the C library. It's also not clear it's
worth supporting a new API entry (since e.g. if this goes in it also
needs a test) to save the python client one line of code. On the
positive side I can see there is arguably a missing abstraction on the
library side, as those particular config items are special.
next prev parent reply other threads:[~2017-06-10 11:37 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-06-04 17:20 [PATCH 1/2] python: add bindings for notmuch_database_get_config{, _list} l-m-h
2017-06-04 17:20 ` [PATCH 2/2] python: add convenience function to get named queries l-m-h
2017-06-10 11:37 ` David Bremner [this message]
2017-06-10 11:10 ` [PATCH 1/2] python: add bindings for notmuch_database_get_config{, _list} David Bremner
2017-06-20 20:06 ` Lucas Hoffmann
2017-06-26 23:19 ` David Bremner
2017-12-07 11:40 ` [PATCH 0/6] " l-m-h
2017-12-19 11:13 ` David Bremner
2017-12-07 11:40 ` [PATCH 1/6] python: add bindings to access config l-m-h
2017-12-07 11:40 ` [PATCH 2/6] python: add default arg to get_config_list l-m-h
2017-12-07 11:40 ` [PATCH 3/6] python: turn get_config_list into a generator l-m-h
2017-12-07 11:40 ` [PATCH 4/6] test: Add tests for new python bindings l-m-h
2017-12-07 11:40 ` [PATCH 5/6] python: Rename get_config_list to get_configs l-m-h
2017-12-22 21:59 ` David Bremner
2017-12-22 22:26 ` [PATCH 0/1] " l-m-h
2017-12-22 22:26 ` [PATCH 1/1] python: Fix method name in docs l-m-h
2017-12-24 14:05 ` David Bremner
2017-12-07 11:40 ` [PATCH 6/6] test: Add test to unset config items with the python bindings l-m-h
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://notmuchmail.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87wp8kcbvg.fsf@tethera.net \
--to=david@tethera.net \
--cc=l-m-h@web.de \
--cc=notmuch@notmuchmail.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://yhetil.org/notmuch.git/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).