From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <david@tethera.net>
Received: from localhost (localhost [127.0.0.1])
 by arlo.cworth.org (Postfix) with ESMTP id 46CB06DE2FBC
 for <notmuch@notmuchmail.org>; Fri, 14 Jul 2017 07:42:48 -0700 (PDT)
X-Virus-Scanned: Debian amavisd-new at cworth.org
X-Spam-Flag: NO
X-Spam-Score: -0.001
X-Spam-Level: 
X-Spam-Status: No, score=-0.001 tagged_above=-999 required=5 tests=[AWL=0.010, 
 SPF_PASS=-0.001, T_RP_MATCHES_RCVD=-0.01] autolearn=disabled
Received: from arlo.cworth.org ([127.0.0.1])
 by localhost (arlo.cworth.org [127.0.0.1]) (amavisd-new, port 10024)
 with ESMTP id CVLzs5TIRAPG for <notmuch@notmuchmail.org>;
 Fri, 14 Jul 2017 07:42:47 -0700 (PDT)
Received: from fethera.tethera.net (fethera.tethera.net [198.245.60.197])
 by arlo.cworth.org (Postfix) with ESMTPS id 74C146DE2F51
 for <notmuch@notmuchmail.org>; Fri, 14 Jul 2017 07:42:47 -0700 (PDT)
Received: from remotemail by fethera.tethera.net with local (Exim 4.84_2)
 (envelope-from <david@tethera.net>)
 id 1dW1kc-0003o0-Iy; Fri, 14 Jul 2017 10:39:26 -0400
Received: (nullmailer pid 16055 invoked by uid 1000);
 Fri, 14 Jul 2017 14:42:43 -0000
From: David Bremner <david@tethera.net>
To: Daniel Kahn Gillmor <dkg@fifthhorseman.net>,
 Notmuch Mail <notmuch@notmuchmail.org>
Subject: Re: [PATCH 1/2] Ensure that "notmuch reply" succeeds during testing.
In-Reply-To: <20170714130912.24777-1-dkg@fifthhorseman.net>
References: <20170714130912.24777-1-dkg@fifthhorseman.net>
Date: Fri, 14 Jul 2017 11:42:43 -0300
Message-ID: <87wp7bcc64.fsf@tethera.net>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
X-BeenThere: notmuch@notmuchmail.org
X-Mailman-Version: 2.1.23
Precedence: list
List-Id: "Use and development of the notmuch mail system."
 <notmuch.notmuchmail.org>
List-Unsubscribe: <https://notmuchmail.org/mailman/options/notmuch>,
 <mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>
List-Archive: <http://notmuchmail.org/pipermail/notmuch/>
List-Post: <mailto:notmuch@notmuchmail.org>
List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>
List-Subscribe: <https://notmuchmail.org/mailman/listinfo/notmuch>,
 <mailto:notmuch-request@notmuchmail.org?subject=subscribe>
X-List-Received-Date: Fri, 14 Jul 2017 14:42:48 -0000

Daniel Kahn Gillmor <dkg@fifthhorseman.net> writes:

> In some (bad!) cases, "notmuch reply" might fail, or might even
> segfault.  If this happens, it indicates a bug, and the test suite
> should notice it.
> ---
>  test/T220-reply.sh | 28 ++++++++++++++--------------
>  1 file changed, 14 insertions(+), 14 deletions(-)
>
> diff --git a/test/T220-reply.sh b/test/T220-reply.sh
> index 17741e0d..b12109bf 100755
> --- a/test/T220-reply.sh
> +++ b/test/T220-reply.sh
> @@ -9,7 +9,7 @@ add_message '[from]=3D"Sender <sender@example.com>"' \
>  	    '[date]=3D"Tue, 05 Jan 2010 15:43:56 -0000"' \
>  	    '[body]=3D"basic reply test"'
>=20=20
> -output=3D$(notmuch reply id:${gen_msg_id})
> +output=3D$(notmuch reply id:${gen_msg_id} || echo failed)

I wonder if we're going to touch this code if we should DTRT=E2=84=A2 and s=
witch
to redirecting stdin and stderr to a file. Then when we have failures we
will at least have a little bit more information, especially in user bug
reports.

d