From: Daniel Kahn Gillmor <dkg@fifthhorseman.net>
To: David Bremner <david@tethera.net>,
Notmuch Mail <notmuch@notmuchmail.org>
Subject: Re: [PATCH v4] python: add decrypt_policy argument to Database.index_file()
Date: Tue, 19 Dec 2017 14:08:15 -0500 [thread overview]
Message-ID: <87wp1imt7k.fsf@fifthhorseman.net> (raw)
In-Reply-To: <87mv2fc66g.fsf@tethera.net>
[-- Attachment #1: Type: text/plain, Size: 694 bytes --]
On Tue 2017-12-19 07:23:35 -0400, David Bremner wrote:
> Daniel Kahn Gillmor <dkg@fifthhorseman.net> writes:
>
>> +Date: $(date -R)
>> +Message-ID: <simplemsg@crypto.notmuchmail.org>
>> +MIME-Version: 1.0
>> +Content-Type: multipart/encrypted; boundary="=-=-=";
>> + protocol="application/pgp-encrypted"
>> +
>
> Can you explain why you explicitely set the date here? it seems to make
> the test less reproducible. In the end it doesn't matter much because
> your test ignores the date, but I feel like I'm missing something.
There's no good reason for setting it explicitly to "now" in this test.
I'll send a revised patch with a static datestring.
Sorry for the distraction!
--dkg
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 832 bytes --]
next prev parent reply other threads:[~2017-12-19 19:08 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-12-08 6:23 session keys followup, version 3 Daniel Kahn Gillmor
2017-12-08 6:23 ` [PATCH v3 01/15] indexing: Change from try_decrypt to decrypt Daniel Kahn Gillmor
2017-12-08 6:23 ` [PATCH v3 02/15] indexopts: change _try_decrypt to _decrypt_policy Daniel Kahn Gillmor
2017-12-08 6:23 ` [PATCH v3 03/15] lib: convert notmuch decryption policy to an enum Daniel Kahn Gillmor
2017-12-08 6:23 ` [PATCH v3 04/15] crypto: new decryption policy "auto" Daniel Kahn Gillmor
2017-12-08 6:23 ` [PATCH v3 05/15] cli/reply: use decryption policy "auto" by default Daniel Kahn Gillmor
2017-12-08 6:23 ` [PATCH v3 06/15] cli/show: " Daniel Kahn Gillmor
2017-12-08 6:23 ` [PATCH v3 07/15] cli/show, reply: document use of stashed session keys in notmuch-properties Daniel Kahn Gillmor
2017-12-08 6:23 ` [PATCH v3 08/15] cli/new, insert, reindex: update documentation for --decrypt=auto Daniel Kahn Gillmor
2017-12-08 6:23 ` [PATCH v3 09/15] crypto: record whether an actual decryption attempt happened Daniel Kahn Gillmor
2017-12-08 6:23 ` [PATCH v3 10/15] cli/new, insert, reindex: change index.decrypt to "auto" by default Daniel Kahn Gillmor
2017-12-08 6:24 ` [PATCH v3 11/15] cli/reindex: destroy stashed session keys when --decrypt=false Daniel Kahn Gillmor
2017-12-08 6:24 ` [PATCH v3 12/15] crypto: actually stash session keys when decrypt=true Daniel Kahn Gillmor
2017-12-08 6:24 ` [PATCH v3 13/15] crypto: add --decrypt=nostash to avoid stashing session keys Daniel Kahn Gillmor
2017-12-08 6:24 ` [PATCH v3 14/15] docs: clean up documentation about decryption policies Daniel Kahn Gillmor
2017-12-09 2:27 ` David Bremner
2017-12-13 16:38 ` Daniel Kahn Gillmor
2017-12-08 6:24 ` [PATCH v3 15/15] python: add decrypt_policy argument to Database.index_file() Daniel Kahn Gillmor
2017-12-11 23:22 ` [PATCH v4] " Daniel Kahn Gillmor
2017-12-19 11:23 ` David Bremner
2017-12-19 19:08 ` Daniel Kahn Gillmor [this message]
2017-12-19 19:08 ` [PATCH v5] " Daniel Kahn Gillmor
2017-12-24 14:05 ` David Bremner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://notmuchmail.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87wp1imt7k.fsf@fifthhorseman.net \
--to=dkg@fifthhorseman.net \
--cc=david@tethera.net \
--cc=notmuch@notmuchmail.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://yhetil.org/notmuch.git/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).