From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from localhost (localhost [127.0.0.1]) by arlo.cworth.org (Postfix) with ESMTP id A85D26DE010F for ; Fri, 29 Dec 2017 15:05:15 -0800 (PST) X-Virus-Scanned: Debian amavisd-new at cworth.org X-Spam-Flag: NO X-Spam-Score: -0.026 X-Spam-Level: X-Spam-Status: No, score=-0.026 tagged_above=-999 required=5 tests=[AWL=-0.026] autolearn=disabled Received: from arlo.cworth.org ([127.0.0.1]) by localhost (arlo.cworth.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 3zd3DAu4Ar3A for ; Fri, 29 Dec 2017 15:05:12 -0800 (PST) Received: from che.mayfirst.org (che.mayfirst.org [162.247.75.118]) by arlo.cworth.org (Postfix) with ESMTPS id BEABC6DE00DB for ; Fri, 29 Dec 2017 15:05:12 -0800 (PST) Received: from fifthhorseman.net (unknown [38.109.115.130]) by che.mayfirst.org (Postfix) with ESMTPSA id 89F57F99D; Fri, 29 Dec 2017 18:05:09 -0500 (EST) Received: by fifthhorseman.net (Postfix, from userid 1000) id 245EE208CB; Fri, 29 Dec 2017 18:04:58 -0500 (EST) From: Daniel Kahn Gillmor To: David Bremner , Notmuch Mail Subject: Re: [PATCH v4 3/3] cli/reply: make --decrypt take a keyword In-Reply-To: <87zi61zjx3.fsf@tethera.net> References: <20171219164055.20778-1-dkg@fifthhorseman.net> <20171219164055.20778-4-dkg@fifthhorseman.net> <874loha4br.fsf@tethera.net> <87k1x6i560.fsf@fifthhorseman.net> <87zi61zjx3.fsf@tethera.net> Date: Fri, 29 Dec 2017 18:04:55 -0500 Message-ID: <87wp15gmp4.fsf@fifthhorseman.net> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha512; protocol="application/pgp-signature" X-BeenThere: notmuch@notmuchmail.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Use and development of the notmuch mail system." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 29 Dec 2017 23:05:15 -0000 --=-=-= Content-Type: text/plain On Fri 2017-12-29 10:30:00 -0400, David Bremner wrote: > Daniel Kahn Gillmor writes: > >> No, we should not support --decrypt=nostash for show or reply. The >> semantics of the display commands (show, reply) are such that they >> *never* modify the index or stash anything in there. The equivalent for >> the indexing (new, insert, reindex) commands' "--decrypt=nostash" in the >> display commands is simply "--decrypt=true". > > I'm not sure I completely agree, but its a trivial matter to add nostash > later if desired. And it's always easier to add API / command options > than to take them away. yes, true that we can always expand out, and it's more parsimonious to start small. :) It sounds like you were suggesting "--decrypt=nostash" as a synonym for "--decrypt=true" on show/reply, which i confess i didn't fully understand when i wrote my response. If it really makes you feel better to add the alias/synonym, i wouldn't block such a change. But I think the documentation is tricky to write (and trickier to read and trickier still to understand!) if "--decrypt=nostash" means the same thing as "--decrypt=true" in one context, but they mean different things in a different context. I'm still trying to aim for that sweet spot where the smallest possible API guides the user to sensible decisions while still understanding what's going on. :) --dkg --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAEBCgAdFiEEDuW+l5KC2AufdUDxzNLtlNIXOekFAlpGyhcACgkQzNLtlNIX OenPLA/8DLcAOZ4qCLKgqWIcH6LxGZQTXDUOPWAKrrHRYKwX8uadft/5b+bS9tAN Eulp9nbLV1K89z7fRqwdujAUlizUGc94XRB6gDKcgNZ2Rv3EFpeB6x8S9cFoCbjP xI4IIRYWr5OE3R38nzdeg4y6VjZ2mexb8hZTJ/D7uIlR6fnE4SIvAfCrQPA+zFRi xSjz+F08KvL0UuesrhjdA3//wOb76FDfSlUfZFjQPcjOiPEngiOrupOWhFM7di+v 8v6VayLnGfxRy0P6isY//O6hDMsfwBdtTJJdZ6jurhNvO4z8jpNZ8NOZA2XwY7vn YwpoZBupW3ymtpcdYjv1v6lXOQd8z15WGeAUFvdaMWTfa/1LwZBPoZ7ONZ0iarn+ xRp4AQxZ93A29kE/o7zILgNPFg2lOTE/PVTvn5/9peNQ1XI1dWT7c9trHDqAp1YZ wG5DYLKNjuOw8JDNXhWsyRfgk8mfBOK7Ys3KCQKvw5gTT9u+blnOECDD93naRZ9N GftUzq/BxKgaclnOvwXcH59xUNoZC7ODOPu9hRtkl7yebXj7MupPFpk/UMm5qLtn fdvJ88cV8jGz4IHpPUL04/hqy3iNUkD1EGZIeVeCSUH6B4STkQbX2biopNyqQJc2 xXm2hyKysZu1M/o0HHgYYlloemjyMPW+WCZDmATCMbXZFs/QRpo= =dfPF -----END PGP SIGNATURE----- --=-=-=--