unofficial mirror of notmuch@notmuchmail.org
 help / color / mirror / code / Atom feed
From: David Bremner <david@tethera.net>
To: Tomi Ollila <tomi.ollila@iki.fi>, notmuch@notmuchmail.org
Subject: Re: [PATCH] configure: check for links to/from libdir in ldconfig output
Date: Wed, 30 May 2018 09:24:34 -0300	[thread overview]
Message-ID: <87wovltjp9.fsf@tethera.net> (raw)
In-Reply-To: <m2y3g14boa.fsf@guru.guru-group.fi>

Tomi Ollila <tomi.ollila@iki.fi> writes:

> On Tue, May 29 2018, David Bremner wrote:
>
>> If e.g. /lib is a link to /usr/lib, then the latter may not show up in
>> the way we expect in the output of ldconfig. 'test foo -ef bar' checks
>> if foo and bar have the same device and inode numbers. Since (at least
>> in bash, ksh, and zsh) the shell dereferences symlinks before applying
>
> i think you have to add 'dash' to this list in this commit message, as it
> is default /bin/sh in debian (and many debian-derived distributions);
> that is quite common configuration there when the test line in question
> is executed

That's right. I even tested dash, _after_ I sent the patch :P 

What do you think about the risk/benefit of including this in 0.27? I
guess we have lived with this bug for a long time.

d

  reply	other threads:[~2018-05-30 12:24 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-05-26 22:23 setting LIBDIR_IN_LDCONFIG fails if /lib is a symlink to /usr/lib David Bremner
2018-05-27 16:33 ` Tomi Ollila
2018-05-27 22:20   ` David Bremner
2018-05-28 11:41     ` Tomi Ollila
2018-05-30  3:04       ` [PATCH] configure: check for links to/from libdir in ldconfig output David Bremner
2018-05-30 11:37         ` Tomi Ollila
2018-05-30 12:24           ` David Bremner [this message]
2018-05-30 13:03             ` Tomi Ollila
2018-06-02 11:12               ` David Bremner

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://notmuchmail.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87wovltjp9.fsf@tethera.net \
    --to=david@tethera.net \
    --cc=notmuch@notmuchmail.org \
    --cc=tomi.ollila@iki.fi \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://yhetil.org/notmuch.git/

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).