From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from localhost (localhost [127.0.0.1]) by arlo.cworth.org (Postfix) with ESMTP id BB7DE6DE1040 for ; Sat, 25 May 2019 04:41:28 -0700 (PDT) X-Virus-Scanned: Debian amavisd-new at cworth.org X-Spam-Flag: NO X-Spam-Score: -0.946 X-Spam-Level: X-Spam-Status: No, score=-0.946 tagged_above=-999 required=5 tests=[AWL=-0.245, RCVD_IN_DNSWL_LOW=-0.7, SPF_PASS=-0.001] autolearn=disabled Received: from arlo.cworth.org ([127.0.0.1]) by localhost (arlo.cworth.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id O2BZW5UwO_59 for ; Sat, 25 May 2019 04:41:27 -0700 (PDT) Received: from relay8-d.mail.gandi.net (relay8-d.mail.gandi.net [217.70.183.201]) by arlo.cworth.org (Postfix) with ESMTPS id 0C19D6DE0F34 for ; Sat, 25 May 2019 04:41:26 -0700 (PDT) X-Originating-IP: 92.169.116.19 Received: from bababa (lfbn-1-4117-19.w92-169.abo.wanadoo.fr [92.169.116.19]) (Authenticated sender: pierre@atlas.engineer) by relay8-d.mail.gandi.net (Postfix) with ESMTPSA id 6F4CB1BF20A; Sat, 25 May 2019 11:41:23 +0000 (UTC) From: Pierre Neidhardt To: David Bremner , notmuch@notmuchmail.org Subject: Re: [PATCH 2/2] emacs: Allow tagging regions in notmuch-tree In-Reply-To: <87v9xyn5vu.fsf@tethera.net> References: <20190409164712.13198-1-mail@ambrevar.xyz> <20190409164745.13497-1-mail@ambrevar.xyz> <878svhfbx0.fsf@tethera.net> <87d0klz5di.fsf@ambrevar.xyz> <87v9xyn5vu.fsf@tethera.net> Date: Sat, 25 May 2019 13:41:22 +0200 Message-ID: <87woieoj6l.fsf@ambrevar.xyz> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha256; protocol="application/pgp-signature" X-BeenThere: notmuch@notmuchmail.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Use and development of the notmuch mail system." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 25 May 2019 11:41:28 -0000 --=-=-= Content-Type: text/plain Content-Transfer-Encoding: quoted-printable David Bremner writes: >> --8<---------------cut here---------------start------------->8--- >>> guix environment notmuch -- /home/ambrevar/.local/share/emacs/site-lisp= /notmuch/test/T460-emacs-tree.sh >> guix environment: error: execlp: No such file or directory: "/home/ambre= var/.local/share/emacs/site-lisp/notmuch/test/T460-emacs-tree.sh" >> --8<---------------cut here---------------end--------------->8--- > > I can't really help you with Guix, but I suggest setting up some > environment where you can run things in an interactive shell. > > In particular that error seems to be claiming the test file doesn't > exist, which would be easy to debug in an interactive shell. Yup, that's what I did with "guix environment notmuch": it sets up a build environment (and an interactive shell) for notmuch. And I really wonder why it can't find the file, it's there in the interactive shell. It's possible that the error message is a red herring though, I'll look into it. > For better or for worse, our standards are higher for new code. Since > (as you have just observed) minor style problems in existing code tend > to linger unfixed. So would you like me to patch the namespacing along with these changes or leave it for another patch? > I assume you are not using git-send-email because it's difficult for > you; it's not that a big of a deal, although we do prefer series > generated git-send-email for reviewing. I'm using git-send-email on a regular basis, no problem with that. (I wonder why you would think it's difficult for me :p) git-send-email comes with different workflows though, I'm not sure which one Notmuch follows. Do you prefer versioned patch series (e.g. [PATCHv2], etc.) or patch updates sent with "--in-reply-to=3D"? =2D-=20 Pierre Neidhardt https://ambrevar.xyz/ --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAEBCAAdFiEEUPM+LlsMPZAEJKvom9z0l6S7zH8FAlzpKeIACgkQm9z0l6S7 zH9LbQf/ea0h8ZGpZvaixju79ru14A4PivenL3jZQR3baS6x0cIsYFsyreju2Fcp ZmqpomRU6XH8r7ZOBvrc1CdOvlRk6bxV5bQsKBsrzRIz9MlzGYY58NnDGtQ4Nsh9 ZuGbCy2iv67D9/I9l+66MMqKL7/SDYpZThFkGwwfNg780St1GAA2RdFZIsSbjZEK k3vIZctZ9lR3141wq6lnc3OufOWJeoXn9hAApEAzr2meh3hQ8Rrpc6o8tNChlJSE 2D+7ZgaSJ5jSAIAjT9qQfWaWYOWLddX1koLZlxxGhvs2XwhQkskbAnQt4nc2Q9gQ LbgBJSipOxy02chfEvjUQ5c2NTX8nQ== =amN6 -----END PGP SIGNATURE----- --=-=-=--