Re: [PATCH 2/2] emacs: Allow tagging regions in notmuch-tree

[Pierre Neidhardt <mail@ambrevar.xyz>]

[-- Attachment #1: Type: text/plain, Size: 1885 bytes --]

David Bremner <david@tethera.net> writes:

>> --8<---------------cut here---------------start------------->8---
>>> guix environment notmuch -- /home/ambrevar/.local/share/emacs/site-lisp/notmuch/test/T460-emacs-tree.sh
>> guix environment: error: execlp: No such file or directory: "/home/ambrevar/.local/share/emacs/site-lisp/notmuch/test/T460-emacs-tree.sh"
>> --8<---------------cut here---------------end--------------->8---
>
> I can't really help you with Guix, but I suggest setting up some
> environment where you can run things in an interactive shell.
>
> In particular that error seems to be claiming the test file doesn't
> exist, which would be easy to debug in an interactive shell.

Yup, that's what I did with "guix environment notmuch": it sets up a
build environment (and an interactive shell) for notmuch.  And I really
wonder why it can't find the file, it's there in the interactive shell.
It's possible that the error message is a red herring though, I'll look
into it.

> For better or for worse, our standards are higher for new code. Since
> (as you have just observed) minor style problems in existing code tend
> to linger unfixed.

So would you like me to patch the namespacing along with these changes
or leave it for another patch?

> I assume you are not using git-send-email because it's difficult for
> you; it's not that a big of a deal, although we do prefer series
> generated git-send-email for reviewing.

I'm using git-send-email on a regular basis, no problem with that.  (I
wonder why you would think it's difficult for me :p)

git-send-email comes with different workflows though, I'm not sure which
one Notmuch follows.  Do you prefer versioned patch series
(e.g. [PATCHv2], etc.) or patch updates sent with
"--in-reply-to=<message-id-of-the-last-email>"?

-- 
Pierre Neidhardt
https://ambrevar.xyz/

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 487 bytes --]