From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp0 ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms11 with LMTPS id q9a+GWkHTmDofgAA0tVLHw (envelope-from ) for ; Sun, 14 Mar 2021 12:54:01 +0000 Received: from aspmx1.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp0 with LMTPS id QIMYFWkHTmDeewAA1q6Kng (envelope-from ) for ; Sun, 14 Mar 2021 12:54:01 +0000 Received: from mail.notmuchmail.org (nmbug.tethera.net [IPv6:2607:5300:201:3100::1657]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 8E25411CEA for ; Sun, 14 Mar 2021 13:54:00 +0100 (CET) Received: from nmbug.tethera.net (localhost [127.0.0.1]) by mail.notmuchmail.org (Postfix) with ESMTP id 5768120623; Sun, 14 Mar 2021 08:53:56 -0400 (EDT) Received: from fethera.tethera.net (fethera.tethera.net [IPv6:2607:5300:60:c5::1]) by mail.notmuchmail.org (Postfix) with ESMTP id EC0FE1FBBC for ; Sun, 14 Mar 2021 08:53:51 -0400 (EDT) Received: by fethera.tethera.net (Postfix, from userid 1001) id 4261E5FA96; Sun, 14 Mar 2021 08:53:49 -0400 (EDT) Received: (nullmailer pid 140473 invoked by uid 1000); Sun, 14 Mar 2021 12:53:47 -0000 From: David Bremner To: notmuch@notmuchmail.org Subject: Re: Clean up glib / GKeyFile memory use In-Reply-To: <20210306134934.491249-1-david@tethera.net> References: <20210306134934.491249-1-david@tethera.net> Date: Sun, 14 Mar 2021 09:53:47 -0300 Message-ID: <87wnu999r8.fsf@tethera.net> MIME-Version: 1.0 Message-ID-Hash: EHS6YWD4MQOLNSXIO5VKX6SFE3KIZETN X-Message-ID-Hash: EHS6YWD4MQOLNSXIO5VKX6SFE3KIZETN X-MailFrom: david@tethera.net X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; header-match-notmuch.notmuchmail.org-0; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; suspicious-header X-Mailman-Version: 3.2.1 Precedence: list List-Id: "Use and development of the notmuch mail system." List-Help: List-Post: List-Subscribe: List-Unsubscribe: Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit X-Migadu-Flow: FLOW_IN ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1615726440; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:list-id:list-help: list-unsubscribe:list-subscribe:list-post; bh=46c2QJ6+4JDy9xmg8fBspLdhB/Yjhk98+UajMPMqmUw=; b=fAeCxrLOqV68IgOE/CjpmpYXh/7fRvUcY8VgRhZ4A70qnouCMgACRj10x4znI3pFEBkib/ FQ0crzpe7qnOiO6pxra5G1JrwivvDznoHYmESgdJgqWHFz83AHd+EfRCcLauNSLlXHP7L/ mk0N6ZkM2yWy6W7t4+Eh0rn0Ko4yfsTo+fyaMoSbAQrh5vCmoMGMxj4JGV/mU8DwVLnKlo +nPwk3rh0IwJqap6GTRiofetFxw2PE9lInVwed/QavSrZ2+479XiqIfB7k5hvTXjbNgalV I2W7NLr/u+ee2lv+0b6OSTHLPXi3zaLQxQdMx8zcFluxl/7TBG8SA6JwI+yOTQ== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1615726440; a=rsa-sha256; cv=none; b=ICSkMLR6Hq2xKQch9GXpIv+E18580Y8aGIlE1UwX+fERngl7D/3tjFDCjOxkoNnGLxqcYL +9KY0pzgPWe+OvYlcn+1NVR1arrpeRHe12cVgt1wK521CdU0guSQj4gSDX0KWN8cquG5lT UB9dLimnLMA8StjfTBS9OT/84OBGwLoU8R9qvup5t8MW8oS0WWkzSkDLH5iHuPO136hMFz U7wHRudDcLw52QX85ETr9WivkBPJR+o3KjfD9p2Wj5EbqwxOucFkHp6Ulou7VVjQ+yrap0 6rkcwi15L6Cm3Qwi7S+58Iii+Up11KvrXVRtvqvSs35sljL9qFyzM/eYngxUqg== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=none; dmarc=none; spf=pass (aspmx1.migadu.com: domain of notmuch-bounces@notmuchmail.org designates 2607:5300:201:3100::1657 as permitted sender) smtp.mailfrom=notmuch-bounces@notmuchmail.org X-Migadu-Spam-Score: -1.99 Authentication-Results: aspmx1.migadu.com; dkim=none; dmarc=none; spf=pass (aspmx1.migadu.com: domain of notmuch-bounces@notmuchmail.org designates 2607:5300:201:3100::1657 as permitted sender) smtp.mailfrom=notmuch-bounces@notmuchmail.org X-Migadu-Queue-Id: 8E25411CEA X-Spam-Score: -1.99 X-Migadu-Scanner: scn0.migadu.com X-TUID: TIMOktEflhC/ David Bremner writes: > It turns out I was too optimistic / lazy about how the g_key_file API > manages memory. None of the resulting memory leaks are large (unless > you somehow keep War and Peace in your config file), but it is more > tidy to clean them up, and makes it easier to spot more significant > leaks in the already noisy output from valgrind. > > This series applies on top of master. I'll have to rebase the other > config series on top (and possibly clean up a few more glib related > memory leaks). I have a applied a rebased version (on top of the uncrustify patches) to master. d