unofficial mirror of notmuch@notmuchmail.org
 help / color / mirror / code / Atom feed
From: Jonas Bernoulli <jonas@bernoul.li>
To: David Bremner <david@tethera.net>, notmuch@notmuchmail.org
Cc: David Bremner <david@tethera.net>
Subject: Re: [PATCH 2/2] NEWS: summarize changes to emacs interface.
Date: Wed, 28 Apr 2021 10:08:09 +0200	[thread overview]
Message-ID: <87wnsmkf12.fsf@bernoul.li> (raw)
In-Reply-To: <20210427001513.2979331-2-david@tethera.net>

David Bremner <david@tethera.net> writes:

I couldn't wait until tonight. ;)

> This my attempt at a summary based on git log.

You have mostly covers the important bits that users need to
know about.  The only thing I would add is:

Some keymaps used to contain bindings for unnamed commands.  These
lambda expressions have been replaced by named commands (symbols),
to ease customization.

> +Removed or inlined functions and variables:
> + `notmuch-address-locate-command`, `notmuch-folder`,
> + `notmuch-remove-if-not`, `notmuch-search-disjunctive-regexp`,
> + `notmuch-sexp-eof`, `notmuch-split-content-type`,
> + `notmuch-tree-button-activate`,

You overlooked a few
  `notmuch-documentation-first-line`
  `notmuch-hello-trim'
and there's also a rename
  `notmuch-hello-versions` => `notmuch-version`

I would change this to:

Removed, inlined or renamed functions and variables:
  `notmuch-address-locate-command`,
  `notmuch-documentation-first-line`, `notmuch-folder`,
  `notmuch-hello-trim', `notmuch-hello-versions` => `notmuch-version`,
  `notmuch-remove-if-not`, `notmuch-search-disjunctive-regexp`,
  `notmuch-sexp-eof`, `notmuch-split-content-type`, and
  `notmuch-tree-button-activate`.

  reply	other threads:[~2021-04-28  8:08 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-04-27  0:15 [PATCH 1/2] NEWS: mention file deletion speedups David Bremner
2021-04-27  0:15 ` [PATCH 2/2] NEWS: summarize changes to emacs interface David Bremner
2021-04-28  8:08   ` Jonas Bernoulli [this message]
2021-04-28 10:22     ` David Bremner
2021-04-28 10:23 ` [PATCH 1/2] NEWS: mention file deletion speedups David Bremner

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://notmuchmail.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87wnsmkf12.fsf@bernoul.li \
    --to=jonas@bernoul.li \
    --cc=david@tethera.net \
    --cc=notmuch@notmuchmail.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://yhetil.org/notmuch.git/

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).