From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp2 ([2001:41d0:8:6d80::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms0.migadu.com with LMTPS id 2EP3Dx2tvmDb0QAAgWs5BA (envelope-from ) for ; Tue, 08 Jun 2021 01:34:53 +0200 Received: from aspmx1.migadu.com ([2001:41d0:8:6d80::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp2 with LMTPS id UKAsCx2tvmDFbwAAB5/wlQ (envelope-from ) for ; Mon, 07 Jun 2021 23:34:53 +0000 Received: from mail.notmuchmail.org (nmbug.tethera.net [144.217.243.247]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 937FE2BC53 for ; Tue, 8 Jun 2021 01:34:52 +0200 (CEST) Received: from nmbug.tethera.net (localhost [127.0.0.1]) by mail.notmuchmail.org (Postfix) with ESMTP id 738342B1DD; Mon, 7 Jun 2021 19:34:49 -0400 (EDT) Received: from fethera.tethera.net (fethera.tethera.net [198.245.60.197]) by mail.notmuchmail.org (Postfix) with ESMTP id 4344129C43 for ; Mon, 7 Jun 2021 19:34:46 -0400 (EDT) Received: by fethera.tethera.net (Postfix, from userid 1001) id 3B31C5FD25; Mon, 7 Jun 2021 19:34:46 -0400 (EDT) Received: (nullmailer pid 194278 invoked by uid 1000); Mon, 07 Jun 2021 23:34:45 -0000 From: David Bremner To: Tomi Ollila , notmuch@notmuchmail.org Subject: Re: [PATCH 1/3] emacs: fix declare-function definitions with related line breaks In-Reply-To: <20210116171709.2434-1-tomi.ollila@iki.fi> References: <20210116171709.2434-1-tomi.ollila@iki.fi> Date: Mon, 07 Jun 2021 20:34:45 -0300 Message-ID: <87wnr5fduy.fsf@tethera.net> MIME-Version: 1.0 Message-ID-Hash: D7F24X77L3CYXWWYMJ7QX2V74BM76M3V X-Message-ID-Hash: D7F24X77L3CYXWWYMJ7QX2V74BM76M3V X-MailFrom: david@tethera.net X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; header-match-notmuch.notmuchmail.org-0; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; suspicious-header CC: tomi.ollila@iki.fi X-Mailman-Version: 3.2.1 Precedence: list List-Id: "Use and development of the notmuch mail system." List-Help: List-Post: List-Subscribe: List-Unsubscribe: Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit X-Migadu-Flow: FLOW_IN ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1623108892; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:list-id:list-help: list-unsubscribe:list-subscribe:list-post; bh=RySQ7xUTlcDhNpU9OWvRVZ9BSIn3yu7LPyphshTk9og=; b=k16N6U1wBbNXitR3ZwE0EVJl1AKwataO1rAvcWSj2H2PVs7bQvUBPfRT5IURD+XoJwpSoG n5rbUyShawwcSRA5yIvAKcbaS0E2RfPidJe5oiNVBorpCEfH3OKt2xh0l2UWm4o4etW65j pT/xL8uaYVPQ61rN6m9Rr648NW+RuVUtQKilO3kKnQP4OI+/6b4sAQzaFVMJojBIIdZJUA rOSYsCWKJCwIgcuw0iCSZr+tM1s8cge1X2kXMBRTBnm+truZ0GAZ+cRTlJWySp/8hhwUmL Wdc7j+OQJ20dHFhW3E93PjJ1xxs1IXThB0wrhUXUw01jEyvHCtLlRij6pgGMPQ== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1623108892; a=rsa-sha256; cv=none; b=IydAZIqektKz9qE8XzOhxG+qIuAHYlfg7FVPKVSTW5LTCs2rlacR5Opmq3LIt714sr59hi AzmrhB70xCAvkxDspuu3YXZ629eA1SbX/oCvED8LNhy4zD8zQ9C0og2BfckB5b4aWu0Ige R3iWY35Th9TXhvR98JvR//ZF3XwbXb0SIXfThrMTVr93yisHIy3xJJN/hsie89dsGoi9LX pQtS0YPVunx7vr98z6I+hvx8bR66Rzp3BNMsEzmQqK7ft996l6UUm2nMVWibbFIWIy0Uj3 bFfMNTPiE7/7BZhtFrGQVI6wYYakYexsCiqk9BEzFoVM5CGSfyzxBhm9GGeDbA== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=none; dmarc=none; spf=pass (aspmx1.migadu.com: domain of notmuch-bounces@notmuchmail.org designates 144.217.243.247 as permitted sender) smtp.mailfrom=notmuch-bounces@notmuchmail.org X-Migadu-Spam-Score: -2.02 Authentication-Results: aspmx1.migadu.com; dkim=none; dmarc=none; spf=pass (aspmx1.migadu.com: domain of notmuch-bounces@notmuchmail.org designates 144.217.243.247 as permitted sender) smtp.mailfrom=notmuch-bounces@notmuchmail.org X-Migadu-Queue-Id: 937FE2BC53 X-Spam-Score: -2.02 X-Migadu-Scanner: scn0.migadu.com X-TUID: 5vYa/V8d/eJR Tomi Ollila writes: > - declare-function notmuch-unthreaded lacked file name > - declare-function notmuch-search had differently named last arg > - note: check-declare-directory did not complain about that > - declare-function notmuch-search-show-thread without nil > - some functions declared to be in different file than those > existed ("notmuch" -> "notmuch-lib") Applied to master. I did note that we have relaxed the line length for the C code, but maybe the shorter length still makes sense for elisp? d