[PATCH] Drop redundant CFLAGS, was already included in CXXFLAGS

[PATCH] Drop redundant CFLAGS, was already included in CXXFLAGS

[Jed Brown]

[-- Attachment #1: Type: text/plain, Size: 74 bytes --]

---
 Makefile |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

[-- Attachment #2: 0001-Drop-redundant-CFLAGS-was-already-included-in-CXXFLA.patch --]
[-- Type: text/x-patch, Size: 331 bytes --]

diff --git a/Makefile b/Makefile
index b6861e9..f9f7af0 100644
--- a/Makefile
+++ b/Makefile
@@ -32,7 +32,7 @@ include lib/Makefile.local
 include Makefile.config
 
 %.o: %.cc $(all_deps)
-	$(CXX) -c $(CFLAGS) $(CXXFLAGS) $< -o $@
+	$(CXX) -c $(CXXFLAGS) $< -o $@
 
 %.o: %.c $(all_deps)
 	$(CC) -c $(CFLAGS) $< -o $@

Re: [PATCH] Drop redundant CFLAGS, was already included in CXXFLAGS

[Carl Worth]

On Fri, 20 Nov 2009 16:58:15 +0100, Jed Brown <jed@59A2.org> wrote:
>  %.o: %.cc $(all_deps)
> -	$(CXX) -c $(CFLAGS) $(CXXFLAGS) $< -o $@
> +	$(CXX) -c $(CXXFLAGS) $< -o $@

Thanks, Jed!

It was nice to get the patch, (which is pushed now).

But it was even nicer to get the encouragement to display text
attachments *and* to include quoted text attachments in replies. I've
often been frustrated by email programs that wouldn't quote patch
attachments in replies for sake of review. So now at least my email
program no longer has that bug.

-Carl

PS. GPG signatures are no longer silently dropped when presenting
messages. We don't yet present the full signature yet, (and in
particular do not yet verify it), but you can at least now see whether a
signature is present.