From: Carl Worth <cworth@cworth.org>
To: Jan Janak <jan@ryngle.com>, notmuch@notmuchmail.org
Subject: Re: [PATCH] notmuch-new: Test if directory looks like Maildir before skipping tmp.
Date: Fri, 27 Nov 2009 19:41:36 -0800 [thread overview]
Message-ID: <87vdgvjoy7.fsf@yoom.home.cworth.org> (raw)
In-Reply-To: <1259183505-30840-1-git-send-email-jan@ryngle.com>
On Wed, 25 Nov 2009 22:11:45 +0100, Jan Janak <jan@ryngle.com> wrote:
> Files and subdirectories with the name "tmp" that do not look like
> Maildir will still be processed by 'notmuch new'.
This is a nice improvement. I realize we neglected to document the
original "tmp" skipping. This should definitely be safer, (though we
should document this as well).
And this maildir detection will also be useful for the outstanding patch
to add tags based on flags in maildir filenames.
I pushed the patch and then made two, minor whitespace fixes:
> +static int is_maildir (struct dirent **entries, int count)
The function name in the definition here belongs on its own line.
> + if (found == 3) return 1;
Having the action of the "if" statement on the same line as the "if"
itself hides it too much. That also belongs on the next line.
-Carl
prev parent reply other threads:[~2009-11-28 3:41 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-11-25 19:43 [PATCH] notmuch-new: Test if directory looks like Maildir before skipping tmp Jan Janak
2009-11-25 20:12 ` Scott Robinson
2009-11-25 21:21 ` Jan Janak
2009-11-25 21:11 ` Jan Janak
2009-11-28 3:41 ` Carl Worth [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://notmuchmail.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87vdgvjoy7.fsf@yoom.home.cworth.org \
--to=cworth@cworth.org \
--cc=jan@ryngle.com \
--cc=notmuch@notmuchmail.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://yhetil.org/notmuch.git/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).