unofficial mirror of notmuch@notmuchmail.org
 help / color / mirror / code / Atom feed
From: Carl Worth <cworth@cworth.org>
To: david@tethera.net, notmuch@notmuchmail.org
Cc: David Bremner <bremner@unb.ca>
Subject: Fix viewing of thread after accidentally archiving.
Date: Thu, 10 Dec 2009 10:43:15 -0800	[thread overview]
Message-ID: <87vdgefz5o.fsf@yoom.home.cworth.org> (raw)
In-Reply-To: <1260458075-12370-1-git-send-email-david@tethera.net>

[-- Attachment #1: Type: text/plain, Size: 1232 bytes --]

On Thu, 10 Dec 2009 11:14:35 -0400, david@tethera.net wrote:
> From: David Bremner <bremner@unb.ca>
> 
> This fixes the annoying bug of archiving a thread, and then going back
> to open it and getting an error.  It needs the notmuch-show API
> changing patch of 1259979997-31544-3-git-send-email-david@tethera.net.
> ---
> 
> I'm not really expecting Carl to push this patch, because I think he
> has a better solution in mind, but in the mean time maybe someone
> finds it useful. It is saving my sanity already, since in wanderlust
>  'a' = reply :).

On the contrary, David. I pushed this immediately, so thanks!

I'll still do the other solution, (other interfaces will want it), but
in the meantime, it's *really* nice to have this bug fixed.

I also fixed '+' and '-' to work in this same situation, (so you can
actually put an inbox tag *back* if you accidentally remove it). I
haven't yet fixed '*' for this case, so an accidental '* -inbox' won't
be recoverable with '* +inbox' if the current search is tag:inbox.

I've added a TODO item to fix this, (and the proposed fix there will
incidentally fix '*' to actually provide feedback on the added/removed
tags too, which will also help).

-Carl

[-- Attachment #2: Type: application/pgp-signature, Size: 189 bytes --]

  reply	other threads:[~2009-12-10 18:43 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-12-05  2:26 Patches in support of linking from org-mode david
2009-12-05  2:26 ` [PATCH 1/2] notmuch-search-process-filter: add text properties for authors and subject to each line david
2009-12-05  2:26   ` [PATCH 2/2] notmuch-show: add optional argument for query context instead of using global binding notmuch-search-query-string david
2009-12-10 15:14     ` [PATCH] notmuch.el: patch notmuch-show to call notmuch show without query-context (i.e. without tag:inbox) if the first query returns nothing david
2009-12-10 18:43       ` Carl Worth [this message]
2009-12-05 14:05 ` [PATCH] notmuch-show-get-header: new function; return alist of parsed header fields David Bremner
2010-03-09 18:20 ` Patches in support of linking from org-mode Carl Worth
2010-03-09 20:08   ` David Bremner

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://notmuchmail.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87vdgefz5o.fsf@yoom.home.cworth.org \
    --to=cworth@cworth.org \
    --cc=bremner@unb.ca \
    --cc=david@tethera.net \
    --cc=notmuch@notmuchmail.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://yhetil.org/notmuch.git/

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).