Re: [PATCH] emacs: Do not color non-matching authors by tag

[Michal Sojka <sojkam1@fel.cvut.cz>]

Hi David,

On Thu, 04 Nov 2010, David Edmondson wrote:
> On Fri, 22 Oct 2010 07:42:02 +0200, Michal Sojka <sojkam1@fel.cvut.cz> wrote:
> > Customizing notmuch-search-line-faces to color lines in search result
> > according to tags has the effect that the color overrides other faces
> > set for the line. This is usually what the user wants with the
> > exception that it also colors non-matching authors and it is then not
> > possible to visually distinguish between matching and non-matching
> > authors.
> > 
> > This patch changes the way how are the faces specified in
> > notmuch-search-line-faces applied to the search results. In
> > particular, instead of adding an overlay for the whole line, the
> > existing faces of the line are replaced with what is given in
> > notmuch-search-line-faces. The only exception is that
> > notmuch-search-non-matching-authors face is never replaced.
> > 
> Michal, was this addressed by the patch that Carl recently merged?
> (Commit f99ad42da03afd638bfdfdea92d1cbdd3b510b8f in my copy of the
> repository.)

Unfortunately not. In your patch, the overlay changes the color/face of the
whole line while my patch change the color/face of all parts of the line
except for non-matching authors. With my patch non-matched autors were
always grayed even if the rest of line was colorized.

My patch no loger applies to the current HEAD. I plan to update it some
time later, but if you want to implement this, it would be great :-)

-Michal