From: Jameson Graef Rollins <jrollins@finestructure.net>
To: Felix Geller <fgeller@gmail.com>, notmuch@notmuchmail.org
Subject: Re: [PATCH 1/2] Added variable to toggle message indendation in Emacs' notmuch-show
Date: Mon, 18 Jul 2011 12:14:29 -0700 [thread overview]
Message-ID: <87vcuz2yga.fsf@servo.factory.finestructure.net> (raw)
In-Reply-To: <1311015465-8136-1-git-send-email-fgeller@gmail.com>
[-- Attachment #1: Type: text/plain, Size: 948 bytes --]
Hi, Felix. Thanks for resubmitting these patches. A couple more
comments:
Remember to include a longer log message with you patch. Beyond just
the single line commit message, the patch should also include a longer
commit message, separated from the first line by a blank line, that
explains what exactly the patch is doing and why.
We've also been trying to get in the habit of sending patches to the
test suite *first*, before the patch that actually implements the
change. The reason being that we can apply the test-suite patch first,
see that the feature or bug fix you're trying to implement is not
implemented, then apply the fix and see that everything is working
again.
Now is probably a good time to remind everyone to look at the GIT patch
submission guidlines, which notmuch has been trying to follow (also
linked from http://notmuchmail.org):
http://repo.or.cz/w/git.git?a=blob;f=Documentation/SubmittingPatches;hb=HEAD
jamie.
[-- Attachment #2: Type: application/pgp-signature, Size: 835 bytes --]
next prev parent reply other threads:[~2011-07-18 19:14 UTC|newest]
Thread overview: 35+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-07-11 8:42 [PATCH] Emacs: Add variable to toggle message indentation in a thread Felix Geller
2011-07-11 8:53 ` Dmitry Kurochkin
2011-07-11 9:24 ` Felix Geller
2011-07-11 9:55 ` Dmitry Kurochkin
2011-07-11 10:09 ` Felix Geller
2011-07-11 8:57 ` Daniel Schoepe
2011-07-11 16:32 ` Jameson Graef Rollins
2011-07-12 23:46 ` Felix Geller
2011-07-16 13:25 ` Felix Geller
2011-07-18 18:30 ` Jameson Graef Rollins
2011-07-18 18:57 ` [PATCH 1/2] Added variable to toggle message indendation in Emacs' notmuch-show Felix Geller
2011-07-18 18:57 ` [PATCH 2/2] Test for toggling message indentation Felix Geller
2011-07-18 19:14 ` Jameson Graef Rollins [this message]
2011-07-18 22:28 ` [PATCH] Emacs: Toggle message indentation for threads in notmuch-show Felix Geller
2011-07-18 22:28 ` [PATCH 1/2] Emacs: Test for turning off indentation of messages in threads Felix Geller
2011-07-18 22:28 ` [PATCH 2/2] Emacs: Add variable to toggle thread indentation to notmuch-show Felix Geller
2011-07-19 10:50 ` configure indentation width instead? (was: Re: [PATCH 2/2] Emacs: Add variable to toggle thread indentation to notmuch-show) Gregor Zattler
2011-08-16 20:24 ` Michal Sojka
2011-10-23 16:43 ` [PATCH] emacs: make message indentation width customisable (was: Re: configure indentation width instead?) Gregor Zattler
2011-10-23 16:52 ` [PATCH 1/2] emacs: add customisation for message indentation width Gregor Zattler
2011-10-23 17:00 ` [PATCH] emacs: make message indentation width customisable (was: Re: configure indentation width instead?) David Bremner
2011-10-23 17:00 ` [PATCH 2/2] Emacs: test: notmuch-show for a message thread without the indentation Gregor Zattler
2011-10-23 19:09 ` sorry, this test does not work (was: Re: [PATCH 2/2] Emacs: test: notmuch-show for a message thread without the indentation) Gregor Zattler
2011-10-23 19:38 ` [PATCH 2a/2] emacs: test notmuch-indent-messages-width default Gregor Zattler
2011-11-24 13:13 ` David Bremner
2011-11-24 22:03 ` [PATCH 0/4] emacs: make message indentation width customisable (was: Re: [PATCH 2a/2] emacs: test notmuch-indent-messages-width default) Gregor Zattler
2011-11-24 22:03 ` [PATCH 1/4] emacs: make message indentation width customisable Gregor Zattler
2011-11-24 22:03 ` [PATCH 2/4] emacs: test notmuch-indent-messages-width default Gregor Zattler
2011-11-24 22:03 ` [PATCH 3/4] emacs: test: notmuch show without indentation Gregor Zattler
2011-11-24 22:03 ` [PATCH 4/4] emacs: test notmuch show with fourfold message indentation Gregor Zattler
2011-11-26 5:18 ` [PATCH 0/4] emacs: make message indentation width customisable (was: Re: [PATCH 2a/2] emacs: test notmuch-indent-messages-width default) David Bremner
2011-10-23 19:41 ` [PATCH 2b/2] emacs: test: notmuch show without indentation Gregor Zattler
2011-10-23 19:42 ` [PATCH 2c/2] emacs: test notmuch show with fourfold message indentation Gregor Zattler
2011-07-18 19:04 ` [PATCH] Emacs: Add variable to toggle message indentation in a thread Felix Geller
2011-07-18 19:10 ` David Bremner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://notmuchmail.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87vcuz2yga.fsf@servo.factory.finestructure.net \
--to=jrollins@finestructure.net \
--cc=fgeller@gmail.com \
--cc=notmuch@notmuchmail.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://yhetil.org/notmuch.git/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).