From: Daniel Schoepe <daniel.schoepe@googlemail.com>
To: James Vasile <james@hackervisions.org>,
Michal Sojka <sojkam1@fel.cvut.cz>,
notmuch@notmuchmail.org
Subject: Re: [PATCH] Return maximum of 150 results
Date: Tue, 23 Aug 2011 01:46:00 +0200 [thread overview]
Message-ID: <87vctp103r.fsf@gilead.invalid> (raw)
In-Reply-To: <87vctrq4or.fsf@hackervisions.org>
[-- Attachment #1: Type: text/plain, Size: 773 bytes --]
On Sat, 20 Aug 2011 15:11:00 -0400, James Vasile <james@hackervisions.org> wrote:
> On Fri, 19 Aug 2011 17:00:23 +0200, Michal Sojka <sojkam1@fel.cvut.cz> wrote:
> > If you really want this behavior, I propose to make the default value
> > of notmuch-max-results infinity.
>
> I'm attaching a revised patch that does as you suggest. Thanks.
I think this is a nice feature.
> +(defvar notmuch-max-results 0)
This should probably be a defcustom and it also needs a docstring
(saying, along with a general description, that 0 means "show all
messages"). Changing it so that nil means all messages might be a bit
nicer (since nil says "no maximum number of results" more clearly, I
think) though, but that's probably just me nitpicking.
Cheers,
Daniel
[-- Attachment #2: Type: application/pgp-signature, Size: 835 bytes --]
prev parent reply other threads:[~2011-08-22 23:46 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-08-19 3:15 [PATCH] Return maximum of 150 results James Vasile
2011-08-19 15:00 ` Michal Sojka
2011-08-19 15:37 ` James Vasile
2011-08-19 16:00 ` Michal Sojka
2011-08-19 16:30 ` James Vasile
2011-08-19 18:30 ` Jameson Graef Rollins
2011-08-20 19:11 ` James Vasile
2011-08-22 23:46 ` Daniel Schoepe [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://notmuchmail.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87vctp103r.fsf@gilead.invalid \
--to=daniel.schoepe@googlemail.com \
--cc=james@hackervisions.org \
--cc=notmuch@notmuchmail.org \
--cc=sojkam1@fel.cvut.cz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://yhetil.org/notmuch.git/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).