From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from localhost (localhost [127.0.0.1]) by olra.theworths.org (Postfix) with ESMTP id 64DB3429E25 for ; Tue, 13 Sep 2011 03:19:35 -0700 (PDT) X-Virus-Scanned: Debian amavisd-new at olra.theworths.org X-Spam-Flag: NO X-Spam-Score: -0.799 X-Spam-Level: X-Spam-Status: No, score=-0.799 tagged_above=-999 required=5 tests=[DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_LOW=-0.7] autolearn=disabled Received: from olra.theworths.org ([127.0.0.1]) by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id jBEC-u6ERJX6 for ; Tue, 13 Sep 2011 03:19:34 -0700 (PDT) Received: from mail-bw0-f53.google.com (mail-bw0-f53.google.com [209.85.214.53]) (using TLSv1 with cipher RC4-SHA (128/128 bits)) (No client certificate requested) by olra.theworths.org (Postfix) with ESMTPS id 9D9E7431FB6 for ; Tue, 13 Sep 2011 03:19:34 -0700 (PDT) Received: by bkbzt12 with SMTP id zt12so396993bkb.26 for ; Tue, 13 Sep 2011 03:19:33 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=from:to:cc:subject:in-reply-to:references:user-agent:date :message-id:mime-version:content-type; bh=yow821+2S1CLXCiKfbO3Xk7VY54JPiCcmexWm/1CzkQ=; b=lq8nx/M1kKjymV1vEHYFhmWAi0hL6ksR/BKS0yeI5A9+sv8uevWWj3AynZJy/l0Dtz SzZtWBaA+LvEF44J6KPZH0qFdP2jEnGoXImyQv6KycDrWHBur6P/lOL8VLY48SLDNvtq hF5cmONu3k2RuV4JD+vjSa81lj7YlpcyBTgX4= Received: by 10.204.7.151 with SMTP id d23mr1847238bkd.19.1315909170631; Tue, 13 Sep 2011 03:19:30 -0700 (PDT) Received: from localhost ([91.144.186.21]) by mx.google.com with ESMTPS id t16sm925397bkv.11.2011.09.13.03.19.27 (version=TLSv1/SSLv3 cipher=OTHER); Tue, 13 Sep 2011 03:19:28 -0700 (PDT) From: Dmitry Kurochkin To: david@tethera.net, notmuch@notmuchmail.org Subject: Re: [PATCH] test: reset test_subtest_known_broken_ after each success/failure. In-Reply-To: <1315881714-23759-1-git-send-email-david@tethera.net> References: <87obyqvc4s.fsf@gmail.com> <1315881714-23759-1-git-send-email-david@tethera.net> User-Agent: Notmuch/0.8-19-g1ca96a5 (http://notmuchmail.org) Emacs/23.3.1 (x86_64-pc-linux-gnu) Date: Tue, 13 Sep 2011 14:19:36 +0400 Message-ID: <87vcswd9s7.fsf@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: David Bremner X-BeenThere: notmuch@notmuchmail.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: "Use and development of the notmuch mail system." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 13 Sep 2011 10:19:35 -0000 On Mon, 12 Sep 2011 23:41:54 -0300, david@tethera.net wrote: > From: David Bremner > > This means that test_subtest_known_broken needs to be called before > every known broken subtest, which is no different than what is > documented for the test_begin_subtest case. > > The assumption is that every test ends up calling either skipping, > calling test_ok_ or test_failure_ and and the latter in turn delegate > to the known_broken versions in the case where > test_subtest_known_broken_ is set. Looks good to me. Regards, Dmitry > --- > test/test-lib.sh | 3 +++ > 1 files changed, 3 insertions(+), 0 deletions(-) > > diff --git a/test/test-lib.sh b/test/test-lib.sh > index 196ef49..966b2dc 100755 > --- a/test/test-lib.sh > +++ b/test/test-lib.sh > @@ -574,12 +574,14 @@ test_failure_message_ () { > } > > test_known_broken_ok_ () { > + test_subtest_known_broken_= > test_fixed=$(($test_fixed+1)) > say_color pass "%-6s" "FIXED" > echo " $@" > } > > test_known_broken_failure_ () { > + test_subtest_known_broken_= > test_broken=$(($test_broken+1)) > test_failure_message_ "BROKEN" "$@" > } > @@ -614,6 +616,7 @@ test_skip () { > fi > case "$to_skip" in > t) > + test_subtest_known_broken_= > say_color skip >&3 "skipping test: $@" > say_color skip "%-6s" "SKIP" > echo " $1" > -- > 1.7.5.4 > > _______________________________________________ > notmuch mailing list > notmuch@notmuchmail.org > http://notmuchmail.org/mailman/listinfo/notmuch