From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from localhost (localhost [127.0.0.1]) by olra.theworths.org (Postfix) with ESMTP id 479BA431FAF for ; Thu, 26 Jan 2012 05:04:15 -0800 (PST) X-Virus-Scanned: Debian amavisd-new at olra.theworths.org X-Spam-Flag: NO X-Spam-Score: -0.7 X-Spam-Level: X-Spam-Status: No, score=-0.7 tagged_above=-999 required=5 tests=[RCVD_IN_DNSWL_LOW=-0.7] autolearn=disabled Received: from olra.theworths.org ([127.0.0.1]) by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id tHAHjek6Ofto for ; Thu, 26 Jan 2012 05:04:14 -0800 (PST) Received: from mail-wi0-f181.google.com (mail-wi0-f181.google.com [209.85.212.181]) (using TLSv1 with cipher RC4-SHA (128/128 bits)) (No client certificate requested) by olra.theworths.org (Postfix) with ESMTPS id D0636431FAE for ; Thu, 26 Jan 2012 05:04:13 -0800 (PST) Received: by wibhi8 with SMTP id hi8so402874wib.26 for ; Thu, 26 Jan 2012 05:04:11 -0800 (PST) Received: by 10.180.87.8 with SMTP id t8mr3990787wiz.15.1327583051377; Thu, 26 Jan 2012 05:04:11 -0800 (PST) Received: from localhost ([109.131.116.159]) by mx.google.com with ESMTPS id cb8sm5340165wib.0.2012.01.26.05.04.10 (version=TLSv1/SSLv3 cipher=OTHER); Thu, 26 Jan 2012 05:04:10 -0800 (PST) From: Pieter Praet To: David Edmondson , Notmuch Mail Subject: Re: [PATCH] emacs: make `notmuch-show-open-or-close-all' toggle visibility In-Reply-To: References: <1327469139-1968-1-git-send-email-pieter@praet.org> User-Agent: Notmuch/0.11+132~ga81001f (http://notmuchmail.org) Emacs/23.3.1 (x86_64-unknown-linux-gnu) Date: Thu, 26 Jan 2012 14:02:15 +0100 Message-ID: <87vcnyvcq0.fsf@praet.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-BeenThere: notmuch@notmuchmail.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: "Use and development of the notmuch mail system." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 26 Jan 2012 13:04:15 -0000 On Wed, 25 Jan 2012 06:35:33 +0000, David Edmondson wrote: > On Wed, 25 Jan 2012 06:25:39 +0100, Pieter Praet wrote: > > * emacs/notmuch-show.el (notmuch-show-open-or-close-all): > > Rename to `notmuch-show-toggle-all-messages', and make it toggle > > visibility of all messages based on the visibility of the current > > message, instead of setting visibility based on whether or not a > > prefix arg was supplied. > > > > Same functionality, less effort (reaching for 'C-u' is a pain)... > > -1. > > The behaviour you've provided is not what I want, from two perspectives: > - currently it's clear what will happen when I use M-RET or > C-uM-RET without me having to think about whether the cursor > is over an open message, > - often I'll be reading an open message and I want to open all > of the rest to look at some context. That's a little more > awkward after this change. I may be missing something, but wouldn't both issues be solved by simply pressing M-RET a second time? I've been using this for a little while now, and IMO it makes navigating through long and diverging threads a lot faster, much like zooming in/out on an outline. How about if C-u M-RET behaved as usual ? > > > > --- > > emacs/notmuch-show.el | 22 ++++++++++++---------- > > 1 files changed, 12 insertions(+), 10 deletions(-) > > > > diff --git a/emacs/notmuch-show.el b/emacs/notmuch-show.el > > index e6a5b31..2d17f74 100644 > > --- a/emacs/notmuch-show.el > > +++ b/emacs/notmuch-show.el > > @@ -1050,8 +1050,8 @@ thread id. If a prefix is given, crypto processing is toggled." > > (define-key map "p" 'notmuch-show-previous-open-message) > > (define-key map (kbd "DEL") 'notmuch-show-rewind) > > (define-key map " " 'notmuch-show-advance-and-archive) > > - (define-key map (kbd "M-RET") 'notmuch-show-open-or-close-all) > > (define-key map (kbd "RET") 'notmuch-show-toggle-message) > > + (define-key map (kbd "M-RET") 'notmuch-show-toggle-all-messages) > > (define-key map "#" 'notmuch-show-print-message) > > map) > > "Keymap for \"notmuch show\" buffers.") > > @@ -1502,16 +1502,18 @@ the result." > > (not (plist-get props :message-visible)))) > > (force-window-update)) > > > > -(defun notmuch-show-open-or-close-all () > > - "Set the visibility all of the messages in the current thread. > > -By default make all of the messages visible. With a prefix > > -argument, hide all of the messages." > > +(defun notmuch-show-toggle-all-messages () > > + "Toggle the visibility of all messages in the current thread. > > +If the current message is visible, hide all messages -- and vice versa." > > (interactive) > > - (save-excursion > > - (goto-char (point-min)) > > - (loop do (notmuch-show-message-visible (notmuch-show-get-message-properties) > > - (not current-prefix-arg)) > > - until (not (notmuch-show-goto-message-next)))) > > + (let ((toggle (notmuch-show-message-visible-p))) > > + (save-excursion > > + (goto-char (point-min)) > > + (loop do (notmuch-show-message-visible > > + (notmuch-show-get-message-properties) > > + (not toggle)) > > + until (not (notmuch-show-goto-message-next))))) > > + (recenter-top-bottom 1) > > (force-window-update)) > > > > (defun notmuch-show-next-button () > > -- > > 1.7.8.1 > > > > _______________________________________________ > > notmuch mailing list > > notmuch@notmuchmail.org > > http://notmuchmail.org/mailman/listinfo/notmuch Peace -- Pieter