Re: [PATCH v4?] emacs: add `notmuch-show-stash-mlarchive-link{, -and-go}'

[Pieter Praet <pieter@praet.org>]

On Fri, 27 Jan 2012 09:18:40 +0000, David Edmondson <dme@dme.org> wrote:
> Much nicer :-)
> 
> On Fri, 27 Jan 2012 09:44:26 +0100, Pieter Praet <pieter@praet.org> wrote:
> > +(defcustom notmuch-show-stash-mlarchive-link-alist
> > +  '(("Gmane" . "http://mid.gmane.org/")
> > +    ("MARC" . "http://marc.info/?i=")
> > +    ("Mail Archive, The" . "http://mail-archive.com/search?l=mid&q=")
> > +    ;; FIXME: can these services be searched by `Message-Id' ?
> > +    ;; ("MarkMail" . "http://markmail.org/")
> > +    ;; ("Nabble" . "http://nabble.com/")
> > +    ;; ("opensubscriber" . "http://opensubscriber.com/")
> > +    )
> > +  "List of Mailing List Archives to use when stashing links."
> > +  :type '(alist :key-type (string :tag "Name")
> > +		:value-type (string :tag "URL"))
> > +  :group 'notmuch-show)
> 
> Add a comment saying that the URI is the result of concatenating this
> with the message id.
> 

Done.


> If someone wants to do something more complicated they can submit
> another patch (maybe it should be an option to have the `cdr' be a
> function that is called with the message id as an argument?).
> 
> > +	   (substring (notmuch-show-get-message-id) 4 -1))))
> 
> We should put this logic in one place and re-use it.

Done.


New patches here:
  id:"1327907574-12760-1-git-send-email-pieter@praet.org"
  id:"1327907574-12760-2-git-send-email-pieter@praet.org"

For some reason, I've marked them as "v2". :/

Note to self: don't send patches while you're still half asleep...


Peace

-- 
Pieter