unofficial mirror of notmuch@notmuchmail.org
 help / color / mirror / code / Atom feed
From: Dmitry Kurochkin <dmitry.kurochkin@gmail.com>
To: David Edmondson <dme@dme.org>, notmuch@notmuchmail.org
Subject: Re: [PATCH] emacs: Move the blank line from the bottom of the headers to the top of the body.
Date: Tue, 31 Jan 2012 15:41:05 +0400	[thread overview]
Message-ID: <87vcnsm75a.fsf@gmail.com> (raw)
In-Reply-To: <1327942340-23340-1-git-send-email-dme@dme.org>

On Mon, 30 Jan 2012 16:52:20 +0000, David Edmondson <dme@dme.org> wrote:
> The blank line doesn't really change position, but is now considered
> to be part of the body rather than part of the headers. This means
> that it is visible when the body is visible rather than when the
> headers are visible.
> ---
> 
> I'm interested in getting feedback on this.
> 
> Unless you run with `notmuch-message-headers-visible' set to `nil' or
> regularly toggle header visibility, you probably don't care.
> 

+1

Regards,
  Dmitry

>  emacs/notmuch-show.el |    4 ++--
>  1 files changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/emacs/notmuch-show.el b/emacs/notmuch-show.el
> index 84ac624..73f73d4 100644
> --- a/emacs/notmuch-show.el
> +++ b/emacs/notmuch-show.el
> @@ -854,8 +854,6 @@ current buffer, if possible."
>      ;; compatible with the existing implementation. This just sets it
>      ;; to after the first header.
>      (notmuch-show-insert-headers headers)
> -    ;; Headers should include a blank line (backwards compatibility).
> -    (insert "\n")
>      (save-excursion
>        (goto-char content-start)
>        ;; If the subject of this message is the same as that of the
> @@ -870,6 +868,8 @@ current buffer, if possible."
>      (setq notmuch-show-previous-subject bare-subject)
>  
>      (setq body-start (point-marker))
> +    ;; A blank line between the headers and the body.
> +    (insert "\n")
>      (notmuch-show-insert-body msg (plist-get msg :body) depth)
>      ;; Ensure that the body ends with a newline.
>      (unless (bolp)
> -- 
> 1.7.8.3
> 
> _______________________________________________
> notmuch mailing list
> notmuch@notmuchmail.org
> http://notmuchmail.org/mailman/listinfo/notmuch

  parent reply	other threads:[~2012-01-31 11:42 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-01-30 16:52 [PATCH] emacs: Move the blank line from the bottom of the headers to the top of the body David Edmondson
2012-01-31  5:25 ` Jameson Graef Rollins
2012-01-31 10:32   ` David Edmondson
2012-01-31 11:34     ` Tomi Ollila
2012-01-31 11:41 ` Dmitry Kurochkin [this message]
2012-02-04 12:39 ` David Bremner

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://notmuchmail.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87vcnsm75a.fsf@gmail.com \
    --to=dmitry.kurochkin@gmail.com \
    --cc=dme@dme.org \
    --cc=notmuch@notmuchmail.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://yhetil.org/notmuch.git/

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).