From: Daniel Kahn Gillmor <dkg@fifthhorseman.net>
To: David Bremner <david@tethera.net>,
Austin Clements <amdragon@MIT.EDU>,
notmuch@notmuchmail.org
Subject: Re: Parsing regression with gmime-2.6?
Date: Thu, 08 Mar 2012 15:30:21 -0500 [thread overview]
Message-ID: <87vcme3kf6.fsf@pip.fifthhorseman.net> (raw)
In-Reply-To: <87wr6xmlml.fsf@zancas.localnet>
[-- Attachment #1: Type: text/plain, Size: 1441 bytes --]
On Tue, 06 Mar 2012 18:04:50 -0400, David Bremner <david@tethera.net> wrote:
> There seems to be something weird going on with gmime-2.6; maybe we
> didn't catch some api change?
This does seem to be a regression in gmime 2.6. I've reported the bug
upstream, along with a simplified (non-notmuch) demonstration:
https://bugzilla.gnome.org/show_bug.cgi?id=671680
We'll see what gmime's upstream has to say about it.
As a devil's advocate, i could argue that a message in a maildir that
starts with a "From " line isn't a proper e-mail message in the first
place, and therefore gmime 2.6 is being more rigorously correct about
what it accepts. In particular, if a user were to place a multi-message
mbox file in their notmuch message store, i think that notmuch linked
against 2.4 would happily index only the first message of it, and the
rest of the message would be "hidden", whereas gmime 2.6 allows us to
detect these failures and avoid indexing them directly.
That said, i understand that this is probably not an entirely rare
situation, and i lean toward the idea that gmime 2.4's behavior was
actually the Right Thing. Also, I haven't been able to find any
explicit documentation to indicate that the behavior change was
a deliberate one.
I'm happy to relay any helpful or constructive suggestions to the gmime
upstream ticket, if folks don't want to deal with bugzilla directly.
--dkg
[-- Attachment #2: Type: application/pgp-signature, Size: 965 bytes --]
next prev parent reply other threads:[~2012-03-08 20:30 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-03-01 21:39 Internal error on line 296 of mime-node.c David Bremner
2012-03-01 21:57 ` Austin Clements
2012-03-02 2:35 ` David Bremner
2012-03-02 2:35 ` [PATCH 1/2] test: utility function to add a pre-generated message to the database David Bremner
2012-03-02 2:35 ` [PATCH 2/2] test: add new test file for mime parsing David Bremner
2012-03-06 18:26 ` [PATCH] Handle errors in mime_node_open Austin Clements
2012-03-06 22:04 ` Parsing regression with gmime-2.6? David Bremner
2012-03-08 15:35 ` [WIP PATCH] debugging gmime-2.6 fail David Bremner
2012-03-08 18:08 ` David Bremner
2012-03-08 18:27 ` Parsing regression with gmime-2.6? Jameson Graef Rollins
2012-03-08 20:30 ` Daniel Kahn Gillmor [this message]
2012-03-08 21:32 ` Jameson Graef Rollins
2012-03-08 21:40 ` Daniel Kahn Gillmor
2012-03-08 21:59 ` Jameson Graef Rollins
2012-03-08 21:48 ` [PATCH] mime_node_open: check if the file is in mbox format, and inform gmime David Bremner
2012-03-08 22:05 ` Jameson Graef Rollins
2012-03-09 10:50 ` Tomi Ollila
2012-03-09 13:31 ` [PATCH] mime_node_open: skip envelope from lines at the start of messages David Bremner
2012-03-09 13:56 ` David Bremner
2012-03-09 16:20 ` Daniel Kahn Gillmor
2012-03-10 13:25 ` David Bremner
2012-03-10 14:45 ` Tomi Ollila
2012-03-11 1:51 ` [PATCH] Handle errors in mime_node_open David Bremner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://notmuchmail.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87vcme3kf6.fsf@pip.fifthhorseman.net \
--to=dkg@fifthhorseman.net \
--cc=amdragon@MIT.EDU \
--cc=david@tethera.net \
--cc=notmuch@notmuchmail.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://yhetil.org/notmuch.git/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).