From: David Bremner <david@tethera.net>
To: Mark Walters <markwalters1009@gmail.com>
Cc: notmuch@notmuchmail.org
Subject: Re: [PATCH v2 (Draft)] emacs: split async json parser into utility function
Date: Sun, 02 Sep 2012 12:51:09 -0300 [thread overview]
Message-ID: <87vcfw779u.fsf@zancas.localnet> (raw)
In-Reply-To: <87k3xlyoek.fsf@qmul.ac.uk>
Mark Walters <markwalters1009@gmail.com> writes:
> Split out the json parser into a utility function.
> ---
>
> Most of this patch is code movement: but I don't see how to arrange the
> patch to show that.
>
"git gui blame notmuch.el" gives some clues, although it isn't perfect.
Maybe you could explain in the commit message what is _not_ code
movement?
> +(defvar notmuch-json-parser nil
> + "Incremental JSON parser.")
This docstring needs expanding. I suppose that this is for internal use,
but it isn't clear from the docstring.
next prev parent reply other threads:[~2012-09-02 15:51 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-07-28 11:48 [PATCH] emacs: move async json parser to its own function Mark Walters
2012-07-29 19:30 ` Mark Walters
2012-07-30 1:35 ` Austin Clements
2012-07-30 20:35 ` Mark Walters
2012-07-30 20:39 ` [PATCH v2 (Draft)] emacs: split async json parser into utility function Mark Walters
2012-09-02 15:51 ` David Bremner [this message]
2012-10-20 0:30 ` Ethan Glasser-Camp
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://notmuchmail.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87vcfw779u.fsf@zancas.localnet \
--to=david@tethera.net \
--cc=markwalters1009@gmail.com \
--cc=notmuch@notmuchmail.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://yhetil.org/notmuch.git/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).