From: Ethan Glasser-Camp <ethan.glasser.camp@gmail.com>
To: Dmitry Kurochkin <dmitry.kurochkin@gmail.com>,
Jameson Graef Rollins <jrollins@finestructure.net>,
notmuch@notmuchmail.org
Subject: Re: [PATCH 1/2] test: add check for <expected> filename argument for test_expect_equal_file
Date: Fri, 12 Oct 2012 13:42:24 -0400 [thread overview]
Message-ID: <87vcefa8ov.fsf@betacantrips.com> (raw)
In-Reply-To: <87sjishv3e.fsf@gmail.com>
Dmitry Kurochkin <dmitry.kurochkin@gmail.com> writes:
> Actually, we can do both: check file name for consistent diff order
> (from expected to actual) and use file names that the caller provides.
Hi! Reviewing the patch queue a little bit here. It seems like this
patch ended up getting dropped because the other approach (using the
filenames that the caller provided) won out and was even pushed. I'm
therefore marking this series notmuch::obsolete (and also
notmuch::stale since it doesn't apply cleanly).
Ethan
next prev parent reply other threads:[~2012-10-12 17:42 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-02-02 0:04 [PATCH 0/2] test_expect_equal_file arguments check Dmitry Kurochkin
2012-02-02 0:04 ` [PATCH 1/2] test: add check for <expected> filename argument for test_expect_equal_file Dmitry Kurochkin
2012-02-02 18:00 ` Jameson Graef Rollins
2012-02-03 0:18 ` Dmitry Kurochkin
2012-02-03 14:04 ` Dmitry Kurochkin
2012-02-03 21:24 ` Jameson Graef Rollins
2012-02-04 8:28 ` Tomi Ollila
2012-10-12 17:42 ` Ethan Glasser-Camp [this message]
2012-10-18 10:05 ` Tomi Ollila
2012-02-02 0:04 ` [PATCH 2/2] test: fix order and format of test_expect_equal_file arguments Dmitry Kurochkin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://notmuchmail.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87vcefa8ov.fsf@betacantrips.com \
--to=ethan.glasser.camp@gmail.com \
--cc=dmitry.kurochkin@gmail.com \
--cc=jrollins@finestructure.net \
--cc=notmuch@notmuchmail.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://yhetil.org/notmuch.git/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).