From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from localhost (localhost [127.0.0.1]) by olra.theworths.org (Postfix) with ESMTP id D4AE0431FB6 for ; Fri, 19 Oct 2012 00:20:08 -0700 (PDT) X-Virus-Scanned: Debian amavisd-new at olra.theworths.org X-Spam-Flag: NO X-Spam-Score: -0.7 X-Spam-Level: X-Spam-Status: No, score=-0.7 tagged_above=-999 required=5 tests=[RCVD_IN_DNSWL_LOW=-0.7] autolearn=disabled Received: from olra.theworths.org ([127.0.0.1]) by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id KL3dLUhEO5ZL for ; Fri, 19 Oct 2012 00:20:08 -0700 (PDT) Received: from mail-vb0-f53.google.com (mail-vb0-f53.google.com [209.85.212.53]) (using TLSv1 with cipher RC4-SHA (128/128 bits)) (No client certificate requested) by olra.theworths.org (Postfix) with ESMTPS id D7217431FAE for ; Fri, 19 Oct 2012 00:20:07 -0700 (PDT) Received: by mail-vb0-f53.google.com with SMTP id fc21so146222vbb.26 for ; Fri, 19 Oct 2012 00:20:05 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20120113; h=from:to:subject:in-reply-to:references:user-agent:date:message-id :mime-version:content-type:x-gm-message-state; bh=X3wQh40EkhYUDLtRJaDaA8hzT12+nvXO0cMaSnWvWg0=; b=k8WmlZ3S8V3trFddZ0DwG24H51ltYg1qoL0HV4NVDEwhJOEPrIMBLo9kqGg+VyvCUI dlfeOPQbR9ZJiYf5jDUGX1cLmb/DWV6rwd/GxpArIdkfoOPJgTQCmJUnRefrpWEGeei7 E0MjS7kWTigJAgenxgCUg4O5NRp5QtwH5GubcKIyMpMFGnS6HM95PvozOeEZdKMuxwuD IVCA0NVtuvEJutqi0pOIvhZMPaFUZM9VmnNuZuuPtWUN4+nW9+PoDhUUqiye34jnlHqm YQqoG+DK9OjIB4mFPVzDh/yreNKIwdO9B7at/Nx+0J8xadH6QE8Ux5yTpI1gZjYGVwMA Iejw== Received: by 10.52.75.70 with SMTP id a6mr374553vdw.5.1350631205798; Fri, 19 Oct 2012 00:20:05 -0700 (PDT) Received: from localhost ([2001:4b98:dc0:43:216:3eff:fe1b:25f3]) by mx.google.com with ESMTPS id o13sm925528vde.21.2012.10.19.00.20.03 (version=SSLv3 cipher=OTHER); Fri, 19 Oct 2012 00:20:04 -0700 (PDT) From: Jani Nikula To: Adrien Bustany , notmuch@notmuchmail.org Subject: Re: [PATCH v2 0/2] Add flush/reopen methods to notmuch_database_t In-Reply-To: <1350510742-13447-1-git-send-email-adrien@bustany.org> References: <1342723401-26103-1-git-send-email-adrien@bustany.org> <1350510742-13447-1-git-send-email-adrien@bustany.org> User-Agent: Notmuch/0.14+39~ge21970d (http://notmuchmail.org) Emacs/23.2.1 (x86_64-pc-linux-gnu) Date: Fri, 19 Oct 2012 09:19:58 +0200 Message-ID: <87vce7yllt.fsf@nikula.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Gm-Message-State: ALoCoQn2LYc6c0ey5vM1QdDFtJjSTBbKSk5YJMwzDk5v8q1QsRICPZN0Bq5S5D3pTkaK9R08GX6b X-BeenThere: notmuch@notmuchmail.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: "Use and development of the notmuch mail system." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 19 Oct 2012 07:20:09 -0000 On Wed, 17 Oct 2012, Adrien Bustany wrote: > The code of the patches in unchanged, but the formatting issues are now > hopefully fixed. Hi Adrien, please check at what version flush and reopen have been introduced to xapian. If they are new-ish (I don't know, didn't have the time to check), please add appropriate #ifdefs. [1] lays the groundwork for this. We'll also need to decide what is the minimum xapian version required in general, i.e. features earlier than that don't need conditional compilation. BR, Jani. [1] id:"1350487737-32058-2-git-send-email-bgamari.foss@gmail.com"