From: David Bremner <david@tethera.net>
To: Tomi Ollila <tomi.ollila@iki.fi>, notmuch@notmuchmail.org
Cc: tomi.ollila@iki.fi
Subject: Re: [PATCH v3 1/2] notmuch-show.el: import calendar data with public function after CR removal
Date: Wed, 21 Nov 2012 23:48:06 -0400 [thread overview]
Message-ID: <87vccywb61.fsf@zancas.localnet> (raw)
In-Reply-To: <1352376480-29961-2-git-send-email-tomi.ollila@iki.fi>
Tomi Ollila <tomi.ollila@iki.fi> writes:
> notmuch-get-bodypart-content provides raw data to its caller so
> that it can be stored verbatim whenever needed. icalendar functions
> expect Emacs to do EOL conversion for the data given to these. Therefore
> it the CRLF -> LF conversion is now done explicitly.
>
> The calls to private functions icalendar--convert-ical-to-diary and
> icalendar--read-element are replaced with call to public function
> icalendar-import-buffer.
This code looks straightforward to me. Any objections to merging?
next prev parent reply other threads:[~2012-11-22 3:48 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-11-08 12:07 [PATCH v3 0/2] notmuch-show.el: text/calendar part insert fix Tomi Ollila
2012-11-08 12:07 ` [PATCH v3 1/2] notmuch-show.el: import calendar data with public function after CR removal Tomi Ollila
2012-11-22 3:48 ` David Bremner [this message]
2012-11-25 15:19 ` David Bremner
2012-11-08 12:08 ` [PATCH v3 2/2] notmuch-show.el: handle the case where icalendar-import-buffer returns nil Tomi Ollila
2012-11-22 3:51 ` David Bremner
2012-11-22 7:39 ` Tomi Ollila
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://notmuchmail.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87vccywb61.fsf@zancas.localnet \
--to=david@tethera.net \
--cc=notmuch@notmuchmail.org \
--cc=tomi.ollila@iki.fi \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://yhetil.org/notmuch.git/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).