From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from localhost (localhost [127.0.0.1]) by olra.theworths.org (Postfix) with ESMTP id E29E5431FAF for ; Sun, 9 Dec 2012 11:21:20 -0800 (PST) X-Virus-Scanned: Debian amavisd-new at olra.theworths.org X-Spam-Flag: NO X-Spam-Score: 1.401 X-Spam-Level: * X-Spam-Status: No, score=1.401 tagged_above=-999 required=5 tests=[DKIM_ADSP_CUSTOM_MED=0.001, FREEMAIL_FROM=0.001, FREEMAIL_REPLY=2.499, NML_ADSP_CUSTOM_MED=1.2, RCVD_IN_DNSWL_MED=-2.3] autolearn=disabled Received: from olra.theworths.org ([127.0.0.1]) by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id zeRtsn9dOzHz for ; Sun, 9 Dec 2012 11:21:19 -0800 (PST) Received: from mail2.qmul.ac.uk (mail2.qmul.ac.uk [138.37.6.6]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by olra.theworths.org (Postfix) with ESMTPS id 20568431FB6 for ; Sun, 9 Dec 2012 11:21:19 -0800 (PST) Received: from smtp.qmul.ac.uk ([138.37.6.40]) by mail2.qmul.ac.uk with esmtp (Exim 4.71) (envelope-from ) id 1ThmR9-0008Hi-EQ; Sun, 09 Dec 2012 19:21:15 +0000 Received: from 93-97-24-31.zone5.bethere.co.uk ([93.97.24.31] helo=localhost) by smtp.qmul.ac.uk with esmtpsa (TLSv1:AES128-SHA:128) (Exim 4.69) (envelope-from ) id 1ThmR9-0007NF-4e; Sun, 09 Dec 2012 19:21:15 +0000 From: Mark Walters To: notmuch@notmuchmail.org, Peter Wang Subject: Re: [PATCH v4 0/3] indicate length of omitted body content In-Reply-To: <1355057796-19260-1-git-send-email-markwalters1009@gmail.com> References: <1355057796-19260-1-git-send-email-markwalters1009@gmail.com> User-Agent: Notmuch/0.14+155~g7edfdc3 (http://notmuchmail.org) Emacs/23.4.1 (x86_64-pc-linux-gnu) Date: Sun, 09 Dec 2012 19:21:18 +0000 Message-ID: <87vccb2frl.fsf@qmul.ac.uk> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Sender-Host-Address: 93.97.24.31 X-QM-SPAM-Info: Sender has good ham record. :) X-QM-Body-MD5: 6e2b44589f881d169c562ca1d29c7913 (of first 20000 bytes) X-SpamAssassin-Score: -1.2 X-SpamAssassin-SpamBar: - X-SpamAssassin-Report: The QM spam filters have analysed this message to determine if it is spam. We require at least 5.0 points to mark a message as spam. This message scored -1.2 points. Summary of the scoring: * -2.3 RCVD_IN_DNSWL_MED RBL: Sender listed at http://www.dnswl.org/, * medium trust * [138.37.6.40 listed in list.dnswl.org] * 0.0 FREEMAIL_FROM Sender email is commonly abused enduser mail provider * (markwalters1009[at]gmail.com) * 1.0 FREEMAIL_REPLY From and body contain different freemails * 0.1 AWL AWL: From: address is in the auto white-list X-QM-Scan-Virus: ClamAV says the message is clean X-BeenThere: notmuch@notmuchmail.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: "Use and development of the notmuch mail system." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 09 Dec 2012 19:21:21 -0000 On Sun, 09 Dec 2012, Mark Walters wrote: > This is a (trivially) rebased version of > id:1344428872-12374-1-git-send-email-novalazy@gmail.com (There was one > bit of context clash, and a small change to one of the sexp tests to > mirror the same change for the json test) > > > The patch is Peter's not mine so as a reviewer +1 from me. > Hi (sorry Peter I had assumed git send-email would have cc'd you on my rebase earlier today) There was some discussion about this patch series on irc and the general view was favourable but that, for consistency, all omitted parts should received a content-length (including text/html). This is a little messy to code into the if else stuff: Jani suggested putting content-length/content-encoding into a small function. Anyway I had hope it was just a trivial rebase and could go in, but the above will take a bit longer to do neatly so I will leave it for now. I think it could go in relatively easily if resubmitted with this change but I will mark this version `moreinfo'. Best wishes Mark > Best wishes > > Mark > > > Peter Wang (3): > test: normalize only message filenames in show json > show: indicate length, encoding of omitted body content > test: conform to content length, encoding fields > > devel/schemata | 9 ++++++++- > notmuch-show.c | 14 ++++++++++++++ > test/crypto | 30 +++++++++++++++++++++--------- > test/json | 4 +++- > test/multipart | 11 ++++++----- > test/sexp | 2 +- > test/test-lib.sh | 2 +- > 7 files changed, 54 insertions(+), 18 deletions(-) > > -- > 1.7.9.1