unofficial mirror of notmuch@notmuchmail.org
 help / color / mirror / code / Atom feed
From: David Bremner <david@tethera.net>
To: Tomi Valkeinen <tomi.valkeinen@iki.fi>, notmuch@notmuchmail.org
Subject: Re: [PATCH 2/2] lib: fix error handling
Date: Sat, 18 Jan 2014 20:09:21 -0400	[thread overview]
Message-ID: <87vbxgg7da.fsf@zancas.localnet> (raw)
In-Reply-To: <1384837831-9206-2-git-send-email-tomi.valkeinen@iki.fi>

Tomi Valkeinen <tomi.valkeinen@iki.fi> writes:

> Currently if a Xapian exception happens in notmuch_message_get_header,
> the exception is not caught leading to crash. In
> notmuch_message_get_date the exception is caught, but an internal error
> is raised, again leading to crash.
>
> This patch fixes the error handling by making both functions catch the
> Xapian exceptions, print an error and return NULL or 0.

pushed,

thanks

d

  parent reply	other threads:[~2014-01-19  0:09 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-11-19  5:10 [PATCH 1/2] fix compilation without emacs Tomi Valkeinen
2013-11-19  5:10 ` [PATCH 2/2] lib: fix error handling Tomi Valkeinen
2014-01-13 21:15   ` Tomi Ollila
2014-01-15 13:45     ` David Bremner
2014-01-19  0:09   ` David Bremner [this message]
2013-11-19 10:43 ` [PATCH 1/2] fix compilation without emacs Tomi Ollila
2013-11-19 11:02   ` Tomi Valkeinen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://notmuchmail.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87vbxgg7da.fsf@zancas.localnet \
    --to=david@tethera.net \
    --cc=notmuch@notmuchmail.org \
    --cc=tomi.valkeinen@iki.fi \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
Code repositories for project(s) associated with this public inbox

	https://yhetil.org/notmuch.git/

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).