From: David Bremner <david@tethera.net>
To: Tomi Ollila <tomi.ollila@iki.fi>,
Kushal Kumaran <kushal.kumaran+notmuch@gmail.com>,
notmuch@notmuchmail.org
Subject: Re: Linux-only fdatasync() in 3c13bc
Date: Wed, 07 May 2014 22:17:58 +0900 [thread overview]
Message-ID: <87vbthu3qx.fsf@maritornes.cs.unb.ca> (raw)
In-Reply-To: <m27g5x7o4w.fsf@guru.guru-group.fi>
Tomi Ollila <tomi.ollila@iki.fi> writes:
> On Wed, May 07 2014, Kushal Kumaran <kushal.kumaran+notmuch@gmail.com> wrote:
>
>> Xīcò <xico@atelo.org> writes:
>>
>>> Also, commit 3c13bc introduced a call to fdatasync() which is not
>>> available on FreeBSD, and probably not either on MacOS at least.
>>>
>>
>> fdatasync is POSIX:
>> http://pubs.opengroup.org/onlinepubs/009695399/functions/fdatasync.html
>
> No wonder it is problematic, then >;)
>
I seem to recall Austin saying on IRC that this usage was guaranteed to
call fsync anyway. Comments Austin?
d
next prev parent reply other threads:[~2014-05-07 13:21 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-05-06 19:59 Linux-only fdatasync() in 3c13bc Xīcò
2014-05-07 11:20 ` Kushal Kumaran
2014-05-07 12:46 ` Tomi Ollila
2014-05-07 13:17 ` David Bremner [this message]
2014-05-07 17:18 ` Austin Clements
2014-05-08 11:57 ` [PATCH] notmuch-dump: use fsync instead of fdatasync David Bremner
2014-05-08 15:36 ` Tomi Ollila
2014-05-17 21:46 ` David Bremner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://notmuchmail.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87vbthu3qx.fsf@maritornes.cs.unb.ca \
--to=david@tethera.net \
--cc=kushal.kumaran+notmuch@gmail.com \
--cc=notmuch@notmuchmail.org \
--cc=tomi.ollila@iki.fi \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://yhetil.org/notmuch.git/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).