Re: [PATCH] lib, ruby: make use of -Wl,--no-undefined configurable

[David Bremner <david@tethera.net>]

Jinwoo Lee <jinwoo68@gmail.com> writes:
>  FAIL   PATH is set to build directory
> 	--- T000-basic.11.expected	2015-06-16 23:40:30.000000000 +0000
> 	+++ T000-basic.11.output	2015-06-16 23:40:30.000000000 +0000
> 	@@ -1 +1 @@
> 	-/Users/jinwoo/Box Sync/personal/project/notmuch
> 	+
> usage: dirname path

This failure is because of spaces in your pathname. It might be simpler
to run in a different directory rather than fix all the problems this
causes in the test suite.

>  FAIL   notmuch is compiled with debugging symbols
> 	--- T000-basic.12.expected	2015-06-16 23:40:30.000000000 +0000
> 	+++ T000-basic.12.output	2015-06-16 23:40:30.000000000 +0000
> 	@@ -1 +1 @@
> 	-1
> 	+0
> ./T000-basic.sh: line 95: readelf: command not found

This test, as it says, is testing if notmuch was compiled with debugging
symbols.  Rather than yet another special case for mac, I'd be curious
if there is a portable test for this (perhaps using nm?). In any case,
this one test failing should not be fatal.

> ./test-lib.sh: line 1062: $test_results_path: ambiguous redirect
> ./test-lib.sh: line 1063: $test_results_path: ambiguous redirect
> ./test-lib.sh: line 1064: $test_results_path: ambiguous redirect
> ./test-lib.sh: line 1065: $test_results_path: ambiguous redirect
> ./test-lib.sh: line 1066: $test_results_path: ambiguous redirect
> ./test-lib.sh: line 1067: $test_results_path: ambiguous redirect

At a guess, this again has to do with spaces in the pathname. Maybe this
is fixable with more quoting, but it's really independent of mac vs
gnu/linux. In this instance it looks like quoting "test_results_path"
would help.