[PATCH] emacs: Fontify From with message-header-other

[PATCH] emacs: Fontify From with message-header-other

[H. J. Illikainen]

Commit e26d767897e8ab59f05808a12ac5c9c1e3c7030f changed the
fontification of the body associated with the From header to
message-header-from.  However, that face is non-existent, and in
message.el (message-font-lock-keywords) the From-header falls through
and is attributed the message-header-other face.

This commit removes the fontification of the [Ff]rom header in
notmuch-show-mode in order to fontify it using the message-header-other
face.

This only affects non-default configurations where
notmuch-message-headers is set to display From.
---
 emacs/notmuch-show.el | 2 --
 1 file changed, 2 deletions(-)

diff --git a/emacs/notmuch-show.el b/emacs/notmuch-show.el
index 49fd198..793f1a5 100644
--- a/emacs/notmuch-show.el
+++ b/emacs/notmuch-show.el
@@ -353,8 +353,6 @@ operation on the contents of the current buffer."
 		'message-header-cc)
 	       ((looking-at "[Ss]ubject:")
 		'message-header-subject)
-	       ((looking-at "[Ff]rom:")
-		'message-header-from)
 	       (t
 		'message-header-other))))
 
-- 
H. J. Illikainen

Re: [PATCH] emacs: Fontify From with message-header-other

[Tomi Ollila]

On Thu, Nov 05 2015, "H. J. Illikainen" <hji@dyntopia.com> wrote:

> Commit e26d767897e8ab59f05808a12ac5c9c1e3c7030f changed the
> fontification of the body associated with the From header to
> message-header-from.  However, that face is non-existent, and in
> message.el (message-font-lock-keywords) the From-header falls through
> and is attributed the message-header-other face.
>
> This commit removes the fontification of the [Ff]rom header in
> notmuch-show-mode in order to fontify it using the message-header-other
> face.
>
> This only affects non-default configurations where
> notmuch-message-headers is set to display From.

I grepped emacs 24.3 sources for message-header-subject and
message-header-from and, indeed, there is not reference to 
message-header-from (but plenty of message-header-subject).

So, to me this change looks good (and trivial) -- I have not
tested it (yet), though.

Tomi

> ---
>  emacs/notmuch-show.el | 2 --
>  1 file changed, 2 deletions(-)
>
> diff --git a/emacs/notmuch-show.el b/emacs/notmuch-show.el
> index 49fd198..793f1a5 100644
> --- a/emacs/notmuch-show.el
> +++ b/emacs/notmuch-show.el
> @@ -353,8 +353,6 @@ operation on the contents of the current buffer."
>  		'message-header-cc)
>  	       ((looking-at "[Ss]ubject:")
>  		'message-header-subject)
> -	       ((looking-at "[Ff]rom:")
> -		'message-header-from)
>  	       (t
>  		'message-header-other))))
>  
> -- 
> H. J. Illikainen
>
> _______________________________________________
> notmuch mailing list
> notmuch@notmuchmail.org
> https://notmuchmail.org/mailman/listinfo/notmuch

Re: [PATCH] emacs: Fontify From with message-header-other

[Mark Walters]

This looks good to me (and all tests pass) so +1.

Best wishes

Mark

On Wed, 04 Nov 2015, "H. J. Illikainen" <hji@dyntopia.com> wrote:

> Commit e26d767897e8ab59f05808a12ac5c9c1e3c7030f changed the
> fontification of the body associated with the From header to
> message-header-from.  However, that face is non-existent, and in
> message.el (message-font-lock-keywords) the From-header falls through
> and is attributed the message-header-other face.
>
> This commit removes the fontification of the [Ff]rom header in
> notmuch-show-mode in order to fontify it using the message-header-other
> face.
>
> This only affects non-default configurations where
> notmuch-message-headers is set to display From.
> ---
>  emacs/notmuch-show.el | 2 --
>  1 file changed, 2 deletions(-)
>
> diff --git a/emacs/notmuch-show.el b/emacs/notmuch-show.el
> index 49fd198..793f1a5 100644
> --- a/emacs/notmuch-show.el
> +++ b/emacs/notmuch-show.el
> @@ -353,8 +353,6 @@ operation on the contents of the current buffer."
>  		'message-header-cc)
>  	       ((looking-at "[Ss]ubject:")
>  		'message-header-subject)
> -	       ((looking-at "[Ff]rom:")
> -		'message-header-from)
>  	       (t
>  		'message-header-other))))
>  
> -- 
> H. J. Illikainen
>
> _______________________________________________
> notmuch mailing list
> notmuch@notmuchmail.org
> https://notmuchmail.org/mailman/listinfo/notmuch

Re: [PATCH] emacs: Fontify From with message-header-other

[David Bremner]

"H. J. Illikainen" <hji@dyntopia.com> writes:

> This commit removes the fontification of the [Ff]rom header in
> notmuch-show-mode in order to fontify it using the message-header-other
> face.
>
> This only affects non-default configurations where
> notmuch-message-headers is set to display From.

pushed,

d