From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from localhost (localhost [127.0.0.1]) by arlo.cworth.org (Postfix) with ESMTP id 6C3796DE0ACD for ; Sat, 3 Sep 2016 13:33:21 -0700 (PDT) X-Virus-Scanned: Debian amavisd-new at cworth.org X-Spam-Flag: NO X-Spam-Score: -0.007 X-Spam-Level: X-Spam-Status: No, score=-0.007 tagged_above=-999 required=5 tests=[AWL=0.004, SPF_PASS=-0.001, T_RP_MATCHES_RCVD=-0.01] autolearn=disabled Received: from arlo.cworth.org ([127.0.0.1]) by localhost (arlo.cworth.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id w-8L0hnjw4Ce for ; Sat, 3 Sep 2016 13:33:14 -0700 (PDT) Received: from fethera.tethera.net (fethera.tethera.net [198.245.60.197]) by arlo.cworth.org (Postfix) with ESMTPS id A10816DE0ABE for ; Sat, 3 Sep 2016 13:33:14 -0700 (PDT) Received: from remotemail by fethera.tethera.net with local (Exim 4.84_2) (envelope-from ) id 1bgHci-0003jT-3v; Sat, 03 Sep 2016 16:33:08 -0400 Received: (nullmailer pid 8667 invoked by uid 1000); Sat, 03 Sep 2016 20:33:11 -0000 From: David Bremner To: Mark Walters , notmuch@notmuchmail.org Subject: Re: [PATCH 5/6] Modify our local copy of message-do-fcc In-Reply-To: <1465599772-10297-6-git-send-email-markwalters1009@gmail.com> References: <1465599772-10297-1-git-send-email-markwalters1009@gmail.com> <1465599772-10297-6-git-send-email-markwalters1009@gmail.com> User-Agent: Notmuch/0.22.1+61~g2ce0f13 (https://notmuchmail.org) Emacs/24.5.1 (x86_64-pc-linux-gnu) Date: Sat, 03 Sep 2016 17:33:11 -0300 Message-ID: <87vaycg1vc.fsf@maritornes.cs.unb.ca> MIME-Version: 1.0 Content-Type: text/plain X-BeenThere: notmuch@notmuchmail.org X-Mailman-Version: 2.1.22 Precedence: list List-Id: "Use and development of the notmuch mail system." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 03 Sep 2016 20:33:21 -0000 Mark Walters writes: > + (cons '("Newsgroups" . default) > + rfc2047-header-encoding-alist))) this seems like more message-mode functionality we don't need? I guess it's harmless, but could omit one dynamically bound variable. > + (while list > + (setq file (pop list)) > + (notmuch-fcc-handler file)) > + (kill-buffer (current-buffer))))))) Is it sensible for us to support a list of output destinations? It seems like an odd corner case to me. I guess the amount of extra code is not too high. In any case I suppose it could be a followup (as could my comment above). d