From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <david@tethera.net>
Received: from localhost (localhost [127.0.0.1])
 by arlo.cworth.org (Postfix) with ESMTP id 508236DE0318
 for <notmuch@notmuchmail.org>; Fri, 11 Nov 2016 05:38:57 -0800 (PST)
X-Virus-Scanned: Debian amavisd-new at cworth.org
X-Spam-Flag: NO
X-Spam-Score: -0.006
X-Spam-Level: 
X-Spam-Status: No, score=-0.006 tagged_above=-999 required=5 tests=[AWL=0.005, 
 SPF_PASS=-0.001, T_RP_MATCHES_RCVD=-0.01] autolearn=disabled
Received: from arlo.cworth.org ([127.0.0.1])
 by localhost (arlo.cworth.org [127.0.0.1]) (amavisd-new, port 10024)
 with ESMTP id wrsO1nlVXY_I for <notmuch@notmuchmail.org>;
 Fri, 11 Nov 2016 05:38:56 -0800 (PST)
Received: from fethera.tethera.net (fethera.tethera.net [198.245.60.197])
 by arlo.cworth.org (Postfix) with ESMTPS id 84E026DE024A
 for <notmuch@notmuchmail.org>; Fri, 11 Nov 2016 05:38:56 -0800 (PST)
Received: from remotemail by fethera.tethera.net with local (Exim 4.84_2)
 (envelope-from <david@tethera.net>)
 id 1c5C2N-0004vB-WC; Fri, 11 Nov 2016 08:38:36 -0500
Received: (nullmailer pid 7521 invoked by uid 1000);
 Fri, 11 Nov 2016 13:38:53 -0000
From: David Bremner <david@tethera.net>
To: Mark Walters <markwalters1009@gmail.com>, notmuch@notmuchmail.org
Subject: Re: [PATCH v2] emacs: add compatability functions for emacs 23
In-Reply-To: <87zil65f8c.fsf@tethera.net>
References: <1477736487-31319-1-git-send-email-markwalters1009@gmail.com>
 <8737iy6wt6.fsf@tethera.net> <87zil65f8c.fsf@tethera.net>
Date: Fri, 11 Nov 2016 09:38:53 -0400
Message-ID: <87vavu5e6q.fsf@tethera.net>
MIME-Version: 1.0
Content-Type: text/plain
X-BeenThere: notmuch@notmuchmail.org
X-Mailman-Version: 2.1.22
Precedence: list
List-Id: "Use and development of the notmuch mail system."
 <notmuch.notmuchmail.org>
List-Unsubscribe: <https://notmuchmail.org/mailman/options/notmuch>,
 <mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>
List-Archive: <http://notmuchmail.org/pipermail/notmuch/>
List-Post: <mailto:notmuch@notmuchmail.org>
List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>
List-Subscribe: <https://notmuchmail.org/mailman/listinfo/notmuch>,
 <mailto:notmuch-request@notmuchmail.org?subject=subscribe>
X-List-Received-Date: Fri, 11 Nov 2016 13:38:57 -0000

David Bremner <david@tethera.net> writes:

> The plot thickens. With this patch applied, I can generate an emacs
> segfault with
>
> 1) EMACS=emacs23 ./devel/try-emacs-mua -q
>
> 2) M-x notmuch-search <return>
>
> 3) tag:inbox <return>

OK, I managed to figure out the problem. I had byte compiled the emacs
code with emacs24, and loading that in emacs23 caused all heck to break
loose. With the byte compilation done with a matching version of emacs,
the test suite passes.

So my conclusions from all this fun:

1) since Mark went to the trouble of doing the compatiblity functions,
   we may as well get emacs23 working again.

2) It's getting hard to debug emacs23 problems, and developer time is
   scarce, so at the same time, deprecate emacs23 support, so e.g. after
   the next major release we can just drop it.

3) With the caveat that we plan to drop the compat functions, I leave it
   to mark's judgement whether it's worth putting them in a seperate
   file, or just adding the FSF copyright to the top of the file.