From: David Bremner <david@tethera.net>
To: Tomi Ollila <tomi.ollila@iki.fi>, notmuch@notmuchmail.org
Subject: Re: [PATCH] test: swap order of arguments of test_expect_equal
Date: Thu, 06 Apr 2017 14:40:12 -0300 [thread overview]
Message-ID: <87vaqhv3ib.fsf@tesseract.cs.unb.ca> (raw)
In-Reply-To: <m2pogpwlki.fsf@guru.guru-group.fi>
Tomi Ollila <tomi.ollila@iki.fi> writes:
> On Thu, Apr 06 2017, David Bremner <david@tethera.net> wrote:
>
>> For some reason (probably inherited from git), the order arguments for
>> test_expect_equal was "$output $expected"; this again matters when
>> generating diffs.
>> ---
>
> IMO these both of these should use expected - output argument order.
>
> But more important than that is to get
> id:20170405003630.15104-1-david@tethera.net merged soon so confusion
> of output ends and if someone(tm) is doing near-future test changes
> risk of collisions can be avoided.
OK, pushed the first two to master.
d
next prev parent reply other threads:[~2017-04-06 17:40 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-04-05 0:36 [PATCH 1/2] test: standardize argument order to test_expect_equal_file David Bremner
2017-04-05 0:36 ` [PATCH 2/2] test: remove debugging "output" David Bremner
2017-04-06 1:12 ` [PATCH] test: swap order of arguments of test_expect_equal David Bremner
2017-04-06 16:24 ` Tomi Ollila
2017-04-06 17:40 ` David Bremner [this message]
2017-04-05 6:15 ` [PATCH 1/2] test: standardize argument order to test_expect_equal_file Tomi Ollila
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://notmuchmail.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87vaqhv3ib.fsf@tesseract.cs.unb.ca \
--to=david@tethera.net \
--cc=notmuch@notmuchmail.org \
--cc=tomi.ollila@iki.fi \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://yhetil.org/notmuch.git/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).