From: Daniel Kahn Gillmor <dkg@fifthhorseman.net>
To: Notmuch Mail <notmuch@notmuchmail.org>
Subject: Re: [PATCH 1/2] cli: convert notmuch_bool_t to stdbool
Date: Mon, 09 Oct 2017 18:24:42 -0400 [thread overview]
Message-ID: <87vajoj6xh.fsf@fifthhorseman.net> (raw)
In-Reply-To: <20171007084405.14499-1-jani@nikula.org>
[-- Attachment #1: Type: text/plain, Size: 467 bytes --]
On Sat 2017-10-07 11:44:04 +0300, Jani Nikula wrote:
> C99 stdbool turned 18 this year. There really is no reason to use our
> own, except in the library interface for backward
> compatibility. Convert the cli and test binaries to stdbool.
+1 LGTM.
I'd also be interested in contemplating a switch to stdbool for the
library interface whenever we do the next ABI bump, but that's
presumably something to consider separately.
Thanks for this work, Jani.
--dkg
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 832 bytes --]
prev parent reply other threads:[~2017-10-09 22:24 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-10-07 8:44 [PATCH 1/2] cli: convert notmuch_bool_t to stdbool Jani Nikula
2017-10-07 8:44 ` [PATCH 2/2] lib: convert notmuch_bool_t to stdbool internally Jani Nikula
2017-10-10 1:43 ` David Bremner
2017-10-07 17:05 ` [PATCH 1/2] cli: convert notmuch_bool_t to stdbool Tomi Ollila
2017-10-09 22:24 ` Daniel Kahn Gillmor [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://notmuchmail.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87vajoj6xh.fsf@fifthhorseman.net \
--to=dkg@fifthhorseman.net \
--cc=notmuch@notmuchmail.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://yhetil.org/notmuch.git/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).