unofficial mirror of notmuch@notmuchmail.org
 help / color / mirror / code / Atom feed
From: Daniel Kahn Gillmor <dkg@fifthhorseman.net>
To: "Rollins\, Jameson" <jrollins@caltech.edu>,
	Notmuch Mail <notmuch@notmuchmail.org>
Subject: Re: [PATCH 2/4] util/crypto: identify and repair "Mixed Up" mangled messages
Date: Thu, 30 May 2019 12:46:23 -0400	[thread overview]
Message-ID: <87v9xrj3fk.fsf@fifthhorseman.net> (raw)
In-Reply-To: <87ef4gznu8.fsf@caltech.edu>

[-- Attachment #1: Type: text/plain, Size: 524 bytes --]

On Thu 2019-05-30 02:18:57 +0000, Rollins, Jameson wrote:
> I understand that this fix is for multipart/encrypted messages, but I'm
> not sure I would call the repair function itself a "crypto function".
> Given that I can imagine more repair functions in the future, would it
> make sense to break them out into their own library?

I agree that this technically isn't a "crypto function", and as such
might not belong where i've put it.  What would you think about
util/repair.{c,h} or util/demangling.{c,h} ?

      --dkg

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 227 bytes --]

  reply	other threads:[~2019-05-30 16:54 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-05-28 22:54 Safe and useful handling of "Mixed Up" mangled messages Daniel Kahn Gillmor
2019-05-28 22:54 ` [PATCH 1/4] test: add test for "Mixed-Up Mime" message mangling Daniel Kahn Gillmor
2019-05-28 22:54 ` [PATCH 2/4] util/crypto: identify and repair "Mixed Up" mangled messages Daniel Kahn Gillmor
2019-05-30  2:18   ` Rollins, Jameson
2019-05-30 16:46     ` Daniel Kahn Gillmor [this message]
2019-05-30 17:01       ` Rollins, Jameson
2019-05-28 22:54 ` [PATCH 3/4] index: repair "Mixed Up" messages before indexing Daniel Kahn Gillmor
2019-05-28 22:54 ` [PATCH 4/4] cli/show: show repaired form of "Mixed Up" mangled messages Daniel Kahn Gillmor
2019-05-30  2:08   ` Rollins, Jameson
2019-05-30  2:09     ` Rollins, Jameson
2019-05-30 16:47       ` Daniel Kahn Gillmor
2019-05-30 17:06         ` Rollins, Jameson
2019-05-28 22:58 ` Safe and useful handling " Daniel Kahn Gillmor
2019-05-29 19:37   ` Daniel Kahn Gillmor
2019-05-30  2:21     ` Rollins, Jameson
2019-05-30 17:30       ` Daniel Kahn Gillmor

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://notmuchmail.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87v9xrj3fk.fsf@fifthhorseman.net \
    --to=dkg@fifthhorseman.net \
    --cc=jrollins@caltech.edu \
    --cc=notmuch@notmuchmail.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://yhetil.org/notmuch.git/

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).