From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from localhost (localhost [127.0.0.1]) by arlo.cworth.org (Postfix) with ESMTP id 79E206DE0F4B for ; Mon, 10 Jun 2019 04:20:36 -0700 (PDT) X-Virus-Scanned: Debian amavisd-new at cworth.org X-Spam-Flag: NO X-Spam-Score: 2.252 X-Spam-Level: ** X-Spam-Status: No, score=2.252 tagged_above=-999 required=5 tests=[AWL=0.149, DATE_IN_PAST_12_24=0.804, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_SORBS_WEB=1.5, SPF_PASS=-0.001] autolearn=disabled Received: from arlo.cworth.org ([127.0.0.1]) by localhost (arlo.cworth.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id Bg2J6E9taspD for ; Mon, 10 Jun 2019 04:20:35 -0700 (PDT) Received: from che.mayfirst.org (che.mayfirst.org [162.247.75.118]) by arlo.cworth.org (Postfix) with ESMTPS id 49AF26DE0F4E for ; Mon, 10 Jun 2019 04:20:34 -0700 (PDT) DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/simple; d=fifthhorseman.net; i=@fifthhorseman.net; q=dns/txt; s=2019; t=1560165632; h=from : to : subject : in-reply-to : references : date : message-id : mime-version : content-type : from; bh=2zBJGAwHPiAdHilyH0uWacKhP8CWbCOsE/Y8Xt1Nk9Y=; b=GBebcy0t+DSKbkp8Ossg6/av93r3W91XENF7/tyP/r/0VD/apbH/YVj4 krdcLjxDa3RJrOKvgax/rdvoAoWgAg== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=fifthhorseman.net; i=@fifthhorseman.net; q=dns/txt; s=2019rsa; t=1560165632; h=from : to : subject : in-reply-to : references : date : message-id : mime-version : content-type : from; bh=2zBJGAwHPiAdHilyH0uWacKhP8CWbCOsE/Y8Xt1Nk9Y=; b=da2xw4Btr96E2Z4E9B4gL5z/BQ8ZJw1x2L0zX+TxVeniasCpuf9NFjk1 7XHj3FwVPl4iKS06r3Lwo+4aISnYRm0QaaBi5wf6hRlprYuRGpq9Ze2iSY SC3UI7yN3IBav2LnXeHuOsEdzFQ3bNXgAi1GVYy+bTQjdJetAeGr02dvpZ Vqrp5F5SICh3QpTmICecg3C+LIjQOEfP/KbfNTxuVIFNs2jiZeWEL/XFQz 8SNEIjDEeYxyaElcr699dwIk8Bo660An+1sbNZIemAHRIpsXwkK7sxDF0b dbJC4KNN+OGFRTkOWgyFdHmOIQ4vgariMVIxFwpLhzNf/V5BVeKsYg== Received: from fifthhorseman.net (unknown [41.226.24.149]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by che.mayfirst.org (Postfix) with ESMTPSA id 0091BF9A0; Mon, 10 Jun 2019 07:20:31 -0400 (EDT) Received: by fifthhorseman.net (Postfix, from userid 1000) id ECEA720A1C; Sun, 9 Jun 2019 19:12:00 -0400 (EDT) From: Daniel Kahn Gillmor To: =?utf-8?Q?=C3=96rjan?= Ekeberg , notmuch@notmuchmail.org, David Edmondson Subject: Re: [BUG] emacs: notmuch-mua-attachment-check finds triggering string inside forwarded messages In-Reply-To: <87bm0cc19l.fsf@swing.csc.kth.se> References: <87bm0cc19l.fsf@swing.csc.kth.se> Autocrypt: addr=dkg@fifthhorseman.net; prefer-encrypt=mutual; keydata= mDMEXEK/AhYJKwYBBAHaRw8BAQdAr/gSROcn+6m8ijTN0DV9AahoHGafy52RRkhCZVwxhEe0K0Rh bmllbCBLYWhuIEdpbGxtb3IgPGRrZ0BmaWZ0aGhvcnNlbWFuLm5ldD6ImQQTFggAQQIbAQUJA8Jn AAULCQgHAgYVCgkICwIEFgIDAQIeAQIXgBYhBMS8Lds4zOlkhevpwvIGkReQOOXGBQJcQsbzAhkB AAoJEPIGkReQOOXG4fkBAO1joRxqAZY57PjdzGieXLpluk9RkWa3ufkt3YUVEpH/AP9c+pgIxtyW +FwMQRjlqljuj8amdN4zuEqaCy4hhz/1DbgzBFxCv4sWCSsGAQQB2kcPAQEHQERSZxSPmgtdw6nN u7uxY7bzb9TnPrGAOp9kClBLRwGfiPUEGBYIACYWIQTEvC3bOMzpZIXr6cLyBpEXkDjlxgUCXEK/ iwIbAgUJAeEzgACBCRDyBpEXkDjlxnYgBBkWCAAdFiEEyQ5tNiAKG5IqFQnndhgZZSmuX/gFAlxC v4sACgkQdhgZZSmuX/iVWgD/fCU4ONzgy8w8UCHGmrmIZfDvdhg512NIBfx+Mz9ls5kA/Rq97vz4 z48MFuBdCuu0W/fVqVjnY7LN5n+CQJwGC0MIA7QA/RyY7Sz2gFIOcrns0RpoHr+3WI+won3xCD8+ sVXSHZvCAP98HCjDnw/b0lGuCR7coTXKLIM44/LFWgXAdZjm1wjODbg4BFxCv50SCisGAQQBl1UB BQEBB0BG4iXnHX/fs35NWKMWQTQoRI7oiAUt0wJHFFJbomxXbAMBCAeIfgQYFggAJhYhBMS8Lds4 zOlkhevpwvIGkReQOOXGBQJcQr+dAhsMBQkB4TOAAAoJEPIGkReQOOXGe/cBAPlek5d9xzcXUn/D kY6jKmxe26CTws3ZkbK6Aa5Ey/qKAP0VuPQSCRxA7RKfcB/XrEphfUFkraL06Xn/xGwJ+D0hCw== Date: Mon, 10 Jun 2019 02:12:00 +0300 Message-ID: <87v9xenykf.fsf@fifthhorseman.net> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha512; protocol="application/pgp-signature" X-BeenThere: notmuch@notmuchmail.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Use and development of the notmuch mail system." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 10 Jun 2019 11:20:36 -0000 --=-=-= Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable On Wed 2019-05-08 19:19:18 +0200, =C3=96rjan Ekeberg wrote: > I have found what seems to be a bug, or at least a misbehaviour of the > "missing attachment warning" implemented by the otherwise so nice > notmuch-mua-attachment-check. > > It works fine to detect the regexp for attachments in simple messages. > The problem is that it also triggers the warning if a matching string is > present inside a forwarded message. This is particularly annoying when > forwarding messages originating from MS-Exchange since those seem to > always include a hidden header "X-MS-Has-Attach" where the word "Attach" > constantly leads to false missing-attachment warnings. I've tagged this with notmuch::bug so that it shows up at https://nmbug.notmuchmail.org/status/, and i'm directly cc'ing dme, since i think he's the author of notmuch-mua-attachment-check.=20=20 > Would it be possible to somehow restrict the regexp search to the part > of the message actually being authored? Would it be too simplistic to > end the search at the first occurrence of "\n\n<#" ? that's pretty simplistic, but does seem better than the status quo. do you have a proposed patch? --dkg --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iHUEARYKAB0WIQTJDm02IAobkioVCed2GBllKa5f+AUCXP2SQAAKCRB2GBllKa5f +KAUAQC+UcqG2cQeH3zA2sIwmeoPbHDK78aNHPl/ibejKBSvDAD+J9JDA0AgYcAD TR3mx4l4oZ0yYH96Bv/DR7mVQUQkyQQ= =cI8H -----END PGP SIGNATURE----- --=-=-=--