From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from localhost (localhost [127.0.0.1]) by arlo.cworth.org (Postfix) with ESMTP id 675876DE0F21 for ; Tue, 11 Jun 2019 02:07:56 -0700 (PDT) X-Virus-Scanned: Debian amavisd-new at cworth.org X-Spam-Flag: NO X-Spam-Score: 1.416 X-Spam-Level: * X-Spam-Status: No, score=1.416 tagged_above=-999 required=5 tests=[AWL=0.117, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_SORBS_WEB=1.5, SPF_PASS=-0.001] autolearn=disabled Received: from arlo.cworth.org ([127.0.0.1]) by localhost (arlo.cworth.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id ZL7AVvRXAnhG for ; Tue, 11 Jun 2019 02:07:54 -0700 (PDT) Received: from che.mayfirst.org (che.mayfirst.org [162.247.75.118]) by arlo.cworth.org (Postfix) with ESMTPS id 48C546DE0F19 for ; Tue, 11 Jun 2019 02:07:53 -0700 (PDT) DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/simple; d=fifthhorseman.net; i=@fifthhorseman.net; q=dns/txt; s=2019; t=1560244072; h=from : to : subject : in-reply-to : references : date : message-id : mime-version : content-type : from; bh=M9QMoRAqL0EQ1cdLqjrkEl40GwkpOVJZhqGFR4JXGIE=; b=CTnJ7EbY5Tq6X3yds6WYE3maDY9xbk3qQLLuIlgGu65uLs9eKCUVwy0+ qvwsJVtUv9WV2096zvrsT0TpMRe+Dw== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=fifthhorseman.net; i=@fifthhorseman.net; q=dns/txt; s=2019rsa; t=1560244072; h=from : to : subject : in-reply-to : references : date : message-id : mime-version : content-type : from; bh=M9QMoRAqL0EQ1cdLqjrkEl40GwkpOVJZhqGFR4JXGIE=; b=ANR5QgINjUSbUW/vcOFHS9T+biN4QtKXKEoktUQX7qiFs86bdJ58jYyF N+S2rBOLLmDAbz2+DUbkhzAoTHw760CfQHnIHDvGcnMPwO66OPQ5P/zDjA HVnTp9pp3UlNtW/ZzyNTBmmChqOISpAP06vgDqDyBPOapAK1r8FWFncGH3 5fcYsmLTY2m31/NZdNDpKVWdkPzkmLbWPcpnEGYqGFzN39r6+YMHgF2kYA eYgHKp/Y/GnAfmsZEKpleOrM3xvk1IixONFzzV57to5l1NAV/RvfBpgz/h C9tj49SY2vz/8fUHRghGvAdwSbtBVhNkfoLCmrICA7hrpimm+IZGsw== Received: from fifthhorseman.net (unknown [41.226.24.149]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by che.mayfirst.org (Postfix) with ESMTPSA id 374A1F99F; Tue, 11 Jun 2019 05:07:49 -0400 (EDT) Received: by fifthhorseman.net (Postfix, from userid 1000) id 4727E20452; Tue, 11 Jun 2019 11:59:47 +0300 (+03) From: Daniel Kahn Gillmor To: Tomi Ollila , notmuch@notmuchmail.org Subject: Re: [PATCH V2] test: aggregate-results.sh: consistent style. zero forks. In-Reply-To: <20190610183923.7247-1-tomi.ollila@iki.fi> References: <87blz6plcg.fsf@fifthhorseman.net> <20190610183923.7247-1-tomi.ollila@iki.fi> Autocrypt: addr=dkg@fifthhorseman.net; prefer-encrypt=mutual; keydata= mDMEXEK/AhYJKwYBBAHaRw8BAQdAr/gSROcn+6m8ijTN0DV9AahoHGafy52RRkhCZVwxhEe0K0Rh bmllbCBLYWhuIEdpbGxtb3IgPGRrZ0BmaWZ0aGhvcnNlbWFuLm5ldD6ImQQTFggAQQIbAQUJA8Jn AAULCQgHAgYVCgkICwIEFgIDAQIeAQIXgBYhBMS8Lds4zOlkhevpwvIGkReQOOXGBQJcQsbzAhkB AAoJEPIGkReQOOXG4fkBAO1joRxqAZY57PjdzGieXLpluk9RkWa3ufkt3YUVEpH/AP9c+pgIxtyW +FwMQRjlqljuj8amdN4zuEqaCy4hhz/1DbgzBFxCv4sWCSsGAQQB2kcPAQEHQERSZxSPmgtdw6nN u7uxY7bzb9TnPrGAOp9kClBLRwGfiPUEGBYIACYWIQTEvC3bOMzpZIXr6cLyBpEXkDjlxgUCXEK/ iwIbAgUJAeEzgACBCRDyBpEXkDjlxnYgBBkWCAAdFiEEyQ5tNiAKG5IqFQnndhgZZSmuX/gFAlxC v4sACgkQdhgZZSmuX/iVWgD/fCU4ONzgy8w8UCHGmrmIZfDvdhg512NIBfx+Mz9ls5kA/Rq97vz4 z48MFuBdCuu0W/fVqVjnY7LN5n+CQJwGC0MIA7QA/RyY7Sz2gFIOcrns0RpoHr+3WI+won3xCD8+ sVXSHZvCAP98HCjDnw/b0lGuCR7coTXKLIM44/LFWgXAdZjm1wjODbg4BFxCv50SCisGAQQBl1UB BQEBB0BG4iXnHX/fs35NWKMWQTQoRI7oiAUt0wJHFFJbomxXbAMBCAeIfgQYFggAJhYhBMS8Lds4 zOlkhevpwvIGkReQOOXGBQJcQr+dAhsMBQkB4TOAAAoJEPIGkReQOOXGe/cBAPlek5d9xzcXUn/D kY6jKmxe26CTws3ZkbK6Aa5Ey/qKAP0VuPQSCRxA7RKfcB/XrEphfUFkraL06Xn/xGwJ+D0hCw== Date: Tue, 11 Jun 2019 09:59:46 +0100 Message-ID: <87v9xcebul.fsf@fifthhorseman.net> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha512; protocol="application/pgp-signature" X-BeenThere: notmuch@notmuchmail.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Use and development of the notmuch mail system." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 11 Jun 2019 09:07:56 -0000 --=-=-= Content-Type: text/plain On Mon 2019-06-10 21:39:23 +0300, Tomi Ollila wrote: > - all variables in $((...)) without leading $ > - all comparisons use -gt, -eq or -ne > - no -a nor -o inside [ ... ] expressions > - all indentation levels using one tab > > Dropped unnecessary empty string check when reading results files. > > Replaced pluralize() which was executed in subshell with > pluralize_s(). pluralize_s sets $s to 's' or '' based on value of > $1. Calls to pluralize_s are done in context of current shell, so > no forks to subshells executed. > --- > > V2: added quotes all "$variable" references where empty values or > IFS characters could make a difference. Not in this script, but > servers better example as a usage style elsewhere (where it could > matter). LGTM. Thanks, Tomi! --dkg --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iHUEARYKAB0WIQTJDm02IAobkioVCed2GBllKa5f+AUCXP9tgwAKCRB2GBllKa5f +P42APwOCLIFOeO0/DhUOhrUO/sChgGIPHrRbBwPbo4N0ryYMwEA+hMx1D+VHuT2 Sa1D5dFMATveWvOOZWms4VGWyDx02A0= =w96o -----END PGP SIGNATURE----- --=-=-=--