From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <david@tethera.net>
Received: from localhost (localhost [127.0.0.1])
 by arlo.cworth.org (Postfix) with ESMTP id E3E2F6DE10B8
 for <notmuch@notmuchmail.org>; Fri, 14 Jun 2019 03:30:46 -0700 (PDT)
X-Virus-Scanned: Debian amavisd-new at cworth.org
X-Spam-Flag: NO
X-Spam-Score: -0.05
X-Spam-Level: 
X-Spam-Status: No, score=-0.05 tagged_above=-999 required=5 tests=[AWL=-0.049, 
 SPF_PASS=-0.001] autolearn=disabled
Received: from arlo.cworth.org ([127.0.0.1])
 by localhost (arlo.cworth.org [127.0.0.1]) (amavisd-new, port 10024)
 with ESMTP id t5LhT459hMKu for <notmuch@notmuchmail.org>;
 Fri, 14 Jun 2019 03:30:45 -0700 (PDT)
Received: from fethera.tethera.net (fethera.tethera.net [198.245.60.197])
 by arlo.cworth.org (Postfix) with ESMTPS id 8BBE66DE0352
 for <notmuch@notmuchmail.org>; Fri, 14 Jun 2019 03:30:45 -0700 (PDT)
Received: from remotemail by fethera.tethera.net with local (Exim 4.89)
 (envelope-from <david@tethera.net>)
 id 1hbjTk-0003ha-0l; Fri, 14 Jun 2019 06:30:40 -0400
Received: (nullmailer pid 14888 invoked by uid 1000);
 Fri, 14 Jun 2019 10:30:50 -0000
From: David Bremner <david@tethera.net>
To: Tomi Ollila <tomi.ollila@iki.fi>, notmuch@notmuchmail.org
Subject: Re: [PATCH 4/8] cli: run uncrustify
In-Reply-To: <m2o931b6ug.fsf@guru.guru-group.fi>
References: <20190613110837.6256-1-david@tethera.net>
 <20190613110837.6256-5-david@tethera.net> <m2o931b6ug.fsf@guru.guru-group.fi>
Date: Fri, 14 Jun 2019 07:30:50 -0300
Message-ID: <87v9x8bgrp.fsf@tethera.net>
MIME-Version: 1.0
Content-Type: text/plain
X-BeenThere: notmuch@notmuchmail.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: "Use and development of the notmuch mail system."
 <notmuch.notmuchmail.org>
List-Unsubscribe: <https://notmuchmail.org/mailman/options/notmuch>,
 <mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>
List-Archive: <http://notmuchmail.org/pipermail/notmuch/>
List-Post: <mailto:notmuch@notmuchmail.org>
List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>
List-Subscribe: <https://notmuchmail.org/mailman/listinfo/notmuch>,
 <mailto:notmuch-request@notmuchmail.org?subject=subscribe>
X-List-Received-Date: Fri, 14 Jun 2019 10:30:47 -0000

Tomi Ollila <tomi.ollila@iki.fi> writes:

>> - * 	These default configuration settings are determined as
>> - * 	follows:
>> + *      These default configuration settings are determined as
>> + *      follows:
>
> The change above looks strange, why change tabs to spaces, if not elsewhere

I guess it's because pre-uncrustify there is a space before the
tab. Possibly a bug in uncrustify, but easy to work around by running
M-x whitespace-cleanup on that region first.

>
>>   *
>>   *		database_path:		$MAILDIR, otherwise $HOME/mail
>>   *
>>   *		user_name:		$NAME variable if set, otherwise
>>   *					read from /etc/passwd
>>   *
>> - *		user_primary_mail: 	$EMAIL variable if set, otherwise
>> + *		user_primary_mail:      $EMAIL variable if set, otherwise
>
> The above I',m not sure; '> +' disturbs experience too much ;/
>
> ... have to create worktree and apply series to see better...
>
same here.


>>   *					constructed from the username and
>>   *					hostname of the current machine.