From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from localhost (localhost [127.0.0.1]) by arlo.cworth.org (Postfix) with ESMTP id 5183B6DE10DD for ; Wed, 31 Jul 2019 21:00:12 -0700 (PDT) X-Virus-Scanned: Debian amavisd-new at cworth.org X-Spam-Flag: NO X-Spam-Score: -1.498 X-Spam-Level: X-Spam-Status: No, score=-1.498 tagged_above=-999 required=5 tests=[AWL=1.003, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_MED=-2.3, SPF_PASS=-0.001] autolearn=disabled Received: from arlo.cworth.org ([127.0.0.1]) by localhost (arlo.cworth.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id atJ_6w5HEcGA for ; Wed, 31 Jul 2019 21:00:11 -0700 (PDT) Received: from che.mayfirst.org (che.mayfirst.org [162.247.75.118]) by arlo.cworth.org (Postfix) with ESMTPS id A3A2C6DE10DB for ; Wed, 31 Jul 2019 21:00:11 -0700 (PDT) DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/simple; d=fifthhorseman.net; i=@fifthhorseman.net; q=dns/txt; s=2019; t=1564632010; h=from : to : subject : in-reply-to : references : date : message-id : mime-version : content-type : from; bh=EKZh3UZ+0jKg8mz5wkDAbwn6Ei14nW7gQ5MrotJ32Bk=; b=p3zccfuJVq6KOoj62XFswuTKzCV6X6ljPe5EHB957C+qNKu61hcDSDc0 20GiBTos3TAvLKp4GjjNMWH8pQ6aDQ== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=fifthhorseman.net; i=@fifthhorseman.net; q=dns/txt; s=2019rsa; t=1564632010; h=from : to : subject : in-reply-to : references : date : message-id : mime-version : content-type : from; bh=EKZh3UZ+0jKg8mz5wkDAbwn6Ei14nW7gQ5MrotJ32Bk=; b=Dx+enkqXvnJjpGXA0z7M8KOw7fANusKYh6O2TxABKFfpVaGLJNADf32k dTLTp3dHfPmvIw6XKH6rHwRzMCXsHAhH5vZTgbX7uPejK2M+Vc4l8VeAW5 Dbp++JLUcy+gnmv8elDmUvKqEZaHAVFBap6M6laY2R5l0RWjBzv0pzIvK1 +zAbTB4IxZBC3x5phqO3yS6fJ5YhSOI89Uhy/4VYMLoXMC5EBKsWJT8EOR mZTL5nGh1WmLOqghVZOyea4uRr7fp1ZpXsHhUS9EubsMuaD3NFGVwuC9Sw Kc4OoR+JcDdoURhpl22Lu+rICtX4XQgSt3rRrx0uZkXUcZ2sXbXrUA== Received: from fifthhorseman.net (unknown [IPv6:2001:470:1f07:60d:5cf3:eff:fee2:4b88]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by che.mayfirst.org (Postfix) with ESMTPSA id 4AE58F99D; Thu, 1 Aug 2019 00:00:10 -0400 (EDT) Received: by fifthhorseman.net (Postfix, from userid 1000) id 20B6820200; Wed, 31 Jul 2019 23:29:22 -0400 (EDT) From: Daniel Kahn Gillmor To: David Bremner , Notmuch Mail Subject: Re: [PATCH 4/7] util/crypto: _n_m_crypto_potential_payload returns whether part is the payload In-Reply-To: <87y30dr2xg.fsf@fifthhorseman.net> References: <20190625014107.12452-1-dkg@fifthhorseman.net> <20190625014107.12452-5-dkg@fifthhorseman.net> <878ssetnzv.fsf@tethera.net> <87y30dr2xg.fsf@fifthhorseman.net> Autocrypt: addr=dkg@fifthhorseman.net; prefer-encrypt=mutual; keydata= mDMEXEK/AhYJKwYBBAHaRw8BAQdAr/gSROcn+6m8ijTN0DV9AahoHGafy52RRkhCZVwxhEe0K0Rh bmllbCBLYWhuIEdpbGxtb3IgPGRrZ0BmaWZ0aGhvcnNlbWFuLm5ldD6ImQQTFggAQQIbAQUJA8Jn AAULCQgHAgYVCgkICwIEFgIDAQIeAQIXgBYhBMS8Lds4zOlkhevpwvIGkReQOOXGBQJcQsbzAhkB AAoJEPIGkReQOOXG4fkBAO1joRxqAZY57PjdzGieXLpluk9RkWa3ufkt3YUVEpH/AP9c+pgIxtyW +FwMQRjlqljuj8amdN4zuEqaCy4hhz/1DbgzBFxCv4sWCSsGAQQB2kcPAQEHQERSZxSPmgtdw6nN u7uxY7bzb9TnPrGAOp9kClBLRwGfiPUEGBYIACYWIQTEvC3bOMzpZIXr6cLyBpEXkDjlxgUCXEK/ iwIbAgUJAeEzgACBCRDyBpEXkDjlxnYgBBkWCAAdFiEEyQ5tNiAKG5IqFQnndhgZZSmuX/gFAlxC v4sACgkQdhgZZSmuX/iVWgD/fCU4ONzgy8w8UCHGmrmIZfDvdhg512NIBfx+Mz9ls5kA/Rq97vz4 z48MFuBdCuu0W/fVqVjnY7LN5n+CQJwGC0MIA7QA/RyY7Sz2gFIOcrns0RpoHr+3WI+won3xCD8+ sVXSHZvCAP98HCjDnw/b0lGuCR7coTXKLIM44/LFWgXAdZjm1wjODbg4BFxCv50SCisGAQQBl1UB BQEBB0BG4iXnHX/fs35NWKMWQTQoRI7oiAUt0wJHFFJbomxXbAMBCAeIfgQYFggAJhYhBMS8Lds4 zOlkhevpwvIGkReQOOXGBQJcQr+dAhsMBQkB4TOAAAoJEPIGkReQOOXGe/cBAPlek5d9xzcXUn/D kY6jKmxe26CTws3ZkbK6Aa5Ey/qKAP0VuPQSCRxA7RKfcB/XrEphfUFkraL06Xn/xGwJ+D0hCw== Date: Wed, 31 Jul 2019 23:29:21 -0400 Message-ID: <87v9vhr2b2.fsf@fifthhorseman.net> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha512; protocol="application/pgp-signature" X-BeenThere: notmuch@notmuchmail.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Use and development of the notmuch mail system." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 01 Aug 2019 04:00:12 -0000 --=-=-= Content-Type: text/plain On Wed 2019-07-31 23:15:55 -0400, Daniel Kahn Gillmor wrote: > On Wed 2019-07-31 08:57:56 -0300, David Bremner wrote: >> what about leaving an assert or call to INTERNAL_ERROR here? I'm a bit >> concerned this change is making the code less robust. I guess we'll see >> a segfault, if either is NULL, but that seems bit icky to rely on. > > Sure, INTERNAL_ERROR makes sense, i think. hm, INTERNAL_ERROR is only a valid symbol within libnotmuch, and util/crypto.o is *not* within libnotmuch. So i think i'll use assert, by analogy with hex_encode() in util/hex_encode.c. let me know if you think that's a bad idea for some reason. --dkg --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iHUEARYKAB0WIQTJDm02IAobkioVCed2GBllKa5f+AUCXUJckQAKCRB2GBllKa5f +EugAP4saPCbj9ADpvtTwjCjiRW2PVtzgIXguxOeBy4jLWG2ygEAqq3qFkO+SWjH vQNBlpe6Ur1+icWed+GWGtbqXFsETAc= =B/Y5 -----END PGP SIGNATURE----- --=-=-=--