From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp1 ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms11 with LMTPS id EOBnAsJPuF43HwAA0tVLHw (envelope-from ) for ; Sun, 10 May 2020 19:02:26 +0000 Received: from aspmx1.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp1 with LMTPS id +LEyKM9PuF5NYwAAbx9fmQ (envelope-from ) for ; Sun, 10 May 2020 19:02:39 +0000 Received: from arlo.cworth.org (arlo.cworth.org [50.126.95.6]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) server-signature RSA-PSS (4096 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 5163B940609 for ; Sun, 10 May 2020 19:02:36 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by arlo.cworth.org (Postfix) with ESMTP id 87F0F6DE0F5A; Sun, 10 May 2020 12:02:33 -0700 (PDT) X-Virus-Scanned: Debian amavisd-new at cworth.org Received: from arlo.cworth.org ([127.0.0.1]) by localhost (arlo.cworth.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id xfqwFbOQBKxu; Sun, 10 May 2020 12:02:33 -0700 (PDT) Received: from arlo.cworth.org (localhost [IPv6:::1]) by arlo.cworth.org (Postfix) with ESMTP id 7579C6DE0F7A; Sun, 10 May 2020 12:02:32 -0700 (PDT) Received: from localhost (localhost [127.0.0.1]) by arlo.cworth.org (Postfix) with ESMTP id 0114D6DE0F7A for ; Sun, 10 May 2020 12:02:31 -0700 (PDT) X-Virus-Scanned: Debian amavisd-new at cworth.org Received: from arlo.cworth.org ([127.0.0.1]) by localhost (arlo.cworth.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id GFBQunlglq5l for ; Sun, 10 May 2020 12:02:30 -0700 (PDT) Received: from fethera.tethera.net (fethera.tethera.net [198.245.60.197]) by arlo.cworth.org (Postfix) with ESMTPS id 2357A6DE0F5A for ; Sun, 10 May 2020 12:02:29 -0700 (PDT) Received: from remotemail by fethera.tethera.net with local (Exim 4.92) (envelope-from ) id 1jXrDU-000622-C9; Sun, 10 May 2020 15:02:24 -0400 Received: (nullmailer pid 1485567 invoked by uid 1000); Sun, 10 May 2020 19:02:22 -0000 From: David Bremner To: Daniel Kahn Gillmor , Notmuch Mail Subject: Re: [PATCH 1/2 v2] test-lib: mark function variables as local In-Reply-To: <87imh3mzve.fsf@fifthhorseman.net> References: <20200506235438.100518-1-dkg@fifthhorseman.net> <20200508232438.169867-1-dkg@fifthhorseman.net> <87r1vtib41.fsf@tethera.net> <87imh3mzve.fsf@fifthhorseman.net> Date: Sun, 10 May 2020 16:02:22 -0300 Message-ID: <87v9l3hav5.fsf@tethera.net> MIME-Version: 1.0 X-BeenThere: notmuch@notmuchmail.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Use and development of the notmuch mail system." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Tomi Ollila Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: notmuch-bounces@notmuchmail.org Sender: "notmuch" X-Scanner: scn0 X-Spam-Score: -1.01 Authentication-Results: aspmx1.migadu.com; dkim=none; dmarc=none; spf=pass (aspmx1.migadu.com: domain of notmuch-bounces@notmuchmail.org designates 50.126.95.6 as permitted sender) smtp.mailfrom=notmuch-bounces@notmuchmail.org X-Scan-Result: default: False [-1.01 / 13.00]; ARC_NA(0.00)[]; GENERIC_REPUTATION(0.00)[-0.46194687568992]; MID_RHS_MATCH_FROM(0.00)[]; FROM_HAS_DN(0.00)[]; RCPT_COUNT_THREE(0.00)[3]; R_SPF_ALLOW(-0.20)[+a:c]; IP_REPUTATION_HAM(0.00)[asn: 27017(-0.18), country: US(-0.00), ip: 50.126.95.6(-0.46)]; MIME_GOOD(-0.10)[text/plain]; PREVIOUSLY_DELIVERED(0.00)[notmuch@notmuchmail.org]; DMARC_NA(0.00)[tethera.net]; HAS_LIST_UNSUB(-0.01)[]; DNSWL_BLOCKED(0.00)[50.126.95.6:from]; URIBL_BLOCKED(0.00)[notmuchmail.org:email,fifthhorseman.net:email]; RCVD_TLS_LAST(0.00)[]; TO_DN_ALL(0.00)[]; MX_GOOD(-0.50)[cached: notmuchmail.org]; FORGED_SENDER_MAILLIST(0.00)[]; DWL_DNSWL_FAIL(0.00)[50.126.95.6:server fail]; MAILLIST(-0.20)[mailman]; R_DKIM_NA(0.00)[]; MIME_TRACE(0.00)[0:+]; ASN(0.00)[asn:27017, ipnet:50.126.64.0/18, country:US]; FROM_NEQ_ENVFROM(0.00)[david@tethera.net,notmuch-bounces@notmuchmail.org]; RCVD_COUNT_SEVEN(0.00)[8] X-TUID: 9FD86ztqBS13 Daniel Kahn Gillmor writes: > > yes, that's right. For certain GMime versions, there's an intermediate > breakage. I think you're saying you want me to rerun the series, with > these things split out so that even on systems with older GMime, tests > pass at every commit. I'll try to get that done today. Sounds perfect. d