From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp0 ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms11 with LMTPS id UDazLxv2q18sSwAA0tVLHw (envelope-from ) for ; Wed, 11 Nov 2020 14:32:59 +0000 Received: from aspmx1.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp0 with LMTPS id gA2SKxv2q1/NWQAA1q6Kng (envelope-from ) for ; Wed, 11 Nov 2020 14:32:59 +0000 Received: from mail.notmuchmail.org (nmbug.tethera.net [IPv6:2607:5300:201:3100::1657]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) server-signature RSA-PSS (2048 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 42CF89403A7 for ; Wed, 11 Nov 2020 14:32:59 +0000 (UTC) Received: from nmbug.tethera.net (localhost [127.0.0.1]) by mail.notmuchmail.org (Postfix) with ESMTP id 0371728C0F; Wed, 11 Nov 2020 09:32:54 -0500 (EST) Received: from mail.hostpark.net (mail.hostpark.net [212.243.197.30]) by mail.notmuchmail.org (Postfix) with ESMTPS id 4CF20203D7 for ; Wed, 11 Nov 2020 09:32:51 -0500 (EST) Received: from localhost (localhost [127.0.0.1]) by mail.hostpark.net (Postfix) with ESMTP id 4C154160DD; Wed, 11 Nov 2020 15:32:50 +0100 (CET) X-Virus-Scanned: by Hostpark/NetZone Mailprotection at hostpark.net Received: from mail.hostpark.net ([127.0.0.1]) by localhost (mail1.hostpark.net [127.0.0.1]) (amavisd-new, port 10124) with ESMTP id 8u5lCN7bvvUp; Wed, 11 Nov 2020 15:32:50 +0100 (CET) Received: from customer (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange ECDHE (P-256) server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mail.hostpark.net (Postfix) with ESMTPSA id 230E9160CE; Wed, 11 Nov 2020 15:32:50 +0100 (CET) From: Jonas Bernoulli To: William Casarin , notmuch@notmuchmail.org Subject: Re: [PATCH 01/27] emacs: silence byte-compiler In-Reply-To: <874klznxom.fsf@jb55.com> References: <20201108190311.1397-1-jonas@bernoul.li> <20201108190311.1397-2-jonas@bernoul.li> <874klznxom.fsf@jb55.com> Date: Wed, 11 Nov 2020 15:32:50 +0100 Message-ID: <87v9echskt.fsf@bernoul.li> MIME-Version: 1.0 Message-ID-Hash: 6FMXMO663KHYMYM5ZHIN3BX4BTVPXLZR X-Message-ID-Hash: 6FMXMO663KHYMYM5ZHIN3BX4BTVPXLZR X-MailFrom: jonas@bernoul.li X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; header-match-notmuch.notmuchmail.org-0; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; suspicious-header X-Mailman-Version: 3.2.1 Precedence: list List-Id: "Use and development of the notmuch mail system." List-Help: List-Post: List-Subscribe: List-Unsubscribe: Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit X-Scanner: ns3122888.ip-94-23-21.eu Authentication-Results: aspmx1.migadu.com; dkim=none; dmarc=none; spf=pass (aspmx1.migadu.com: domain of notmuch-bounces@notmuchmail.org designates 2607:5300:201:3100::1657 as permitted sender) smtp.mailfrom=notmuch-bounces@notmuchmail.org X-Spam-Score: -1.01 X-TUID: x36AcBwa6Wrv William Casarin writes: > LGTM, I have a similar patch here: id:20200908171536.20679-1-jb55@jb55.com So if I understood correctly the problem with that was that you were unable to run the tests and therefore couldn't confirm that you fixed the issue or even that there was an issue in the first place. Well I was able to build and test and I can confirm that there is an issue and that your commit fixes it. So it should be merged (though I would merge my own variant because of the extra comment ;-). Cheers, Jonas